You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2022/04/27 05:50:41 UTC
[isis] 01/03: ISIS-2297: java-doc fixes
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
commit 0c073e5239b22b88fd5db06a393295d7b277efe2
Author: Andi Huber <ah...@apache.org>
AuthorDate: Wed Apr 27 07:27:26 2022 +0200
ISIS-2297: java-doc fixes
---
.../org/apache/isis/commons/internal/primitives/_Doubles.java | 4 ++--
.../facets/actions/action/ActionOverloadingValidator.java | 11 +++++++----
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/primitives/_Doubles.java b/commons/src/main/java/org/apache/isis/commons/internal/primitives/_Doubles.java
index 5767fd6592..f30be3e948 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/primitives/_Doubles.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/primitives/_Doubles.java
@@ -44,7 +44,7 @@ public class _Doubles {
/**
* Ignores precision loss.
* @throws ArithmeticException
- * if {@code decimal} cannot not be approximated by {@link Double}.
+ * if {@code decimal} cannot be approximated by {@link Double}.
* @apiNote specifically not using {@link OptionalDouble} as result type here,
* based on how this method is used from value semantics
*/
@@ -56,7 +56,7 @@ public class _Doubles {
/**
* Ignores precision loss.
* @throws ArithmeticException
- * if {@code decimal} cannot not be approximated by {@link Double}.
+ * if {@code decimal} cannot be approximated by {@link Double}.
*/
public double convertToDouble(final @NonNull BigDecimal decimal) {
val doubleValue = decimal.doubleValue();
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/actions/action/ActionOverloadingValidator.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/actions/action/ActionOverloadingValidator.java
index 1afb94724c..1c0cc14ebc 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/actions/action/ActionOverloadingValidator.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/actions/action/ActionOverloadingValidator.java
@@ -21,6 +21,7 @@ package org.apache.isis.core.metamodel.facets.actions.action;
import javax.inject.Inject;
import org.apache.isis.applib.services.metamodel.BeanSort;
+import org.apache.isis.commons.internal.base._Blackhole;
import org.apache.isis.commons.internal.collections._Sets;
import org.apache.isis.core.metamodel.context.MetaModelContext;
import org.apache.isis.core.metamodel.spec.ActionScope;
@@ -56,10 +57,12 @@ extends MetaModelVisitingValidatorAbstract {
val overloadedNames = _Sets.<String>newHashSet();
- spec.streamActions(ActionScope.ANY, MixedIn.EXCLUDED, oa->{
- overloadedNames.add(oa.getFeatureIdentifier().getMemberLogicalName());
- })
- .count(); // consumer the stream
+ _Blackhole.consume( // not strictly required, just to mark this as call with side-effects
+ spec.streamActions(ActionScope.ANY, MixedIn.EXCLUDED, oa->{
+ overloadedNames.add(oa.getFeatureIdentifier().getMemberLogicalName());
+ })
+ .count() // consumes the stream
+ );
if(!overloadedNames.isEmpty()) {