You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by Atry <gi...@git.apache.org> on 2016/04/16 15:48:18 UTC
[GitHub] spark pull request: [SPARK-14683] [Documentation] Configure extern...
GitHub user Atry opened a pull request:
https://github.com/apache/spark/pull/12444
[SPARK-14683] [Documentation] Configure external links in ScalaDoc
Right now Spark's Scaladoc does not link to Scala standard library and other dependencies. This would bother Spark starters because they may be not a experienced Scala programmer.
This patch fixes these links in ScalaDoc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Atry/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12444.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12444
----
commit 4c45ffc0b08f9ee3645d5df376b5b14433c569bd
Author: 杨博 (Yang Bo) <po...@gmail.com>
Date: 2016-04-16T13:40:28Z
Configure external links in ScalaDoc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/12444#issuecomment-215252019
Looks like this broke Scaladoc generation, actually: https://amplab.cs.berkeley.edu/jenkins/view/Spark%20Packaging/job/spark-master-docs/1709/changes#detail2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12444
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12444#issuecomment-210820855
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/12444#issuecomment-215253598
Yep, still broken. I'm going to revert this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by Atry <gi...@git.apache.org>.
Github user Atry commented on the pull request:
https://github.com/apache/spark/pull/12444#issuecomment-210821620
The ScalaDoc URL is hardcoded in the `sbt-api-mappings` plugin. So if one of the ScalaDoc URL of some dependencies changes. We have to update the URL in the `sbt-api-mappings` plugin and update the `sbt-api-mappings` version.
Fortunately, most of Scala libraries are hosted on Maven central repository, their documentation can be visited under `oss.sonatype.org`, which seems not be changed frequently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12444#issuecomment-210872527
Going to merge this. It's easy to revert if we find a problem down the road anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12444#issuecomment-210821041
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12444#issuecomment-210847183
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12444#issuecomment-210847075
**[Test build #56010 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56010/consoleFull)** for PR 12444 at commit [`4c45ffc`](https://github.com/apache/spark/commit/4c45ffc0b08f9ee3645d5df376b5b14433c569bd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/12444#issuecomment-215252296
I'm testing to see whether the updated genjavadoc fixes this, so don't revert for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/12444#issuecomment-215254250
For posterity, here's the error:
```
java.lang.RuntimeException: encoded string too long: 72116 bytes
at scala.sys.package$.error(package.scala:27)
at scala.Predef$.error(Predef.scala:142)
at sbinary.JavaUTF$StringFormat$.writes(javaprotocol.scala:165)
at sbinary.JavaUTF$StringFormat$.writes(javaprotocol.scala:100)
at sbt.InputCache$$anon$1.write(SeparatedCache.scala:24)
at sbt.BasicCacheImplicits$$anon$12$$anonfun$write$2.apply(Cache.scala:125)
at sbt.BasicCacheImplicits$$anon$12$$anonfun$write$2.apply(Cache.scala:125)
at scala.collection.immutable.List.foreach(List.scala:318)
at sbt.BasicCacheImplicits$$anon$12.write(Cache.scala:125)
at sbt.BasicCacheImplicits$$anon$12.write(Cache.scala:112)
at sbt.HListCacheImplicits$$anon$14.write(Cache.scala:169)
at sbt.HListCacheImplicits$$anon$14.write(Cache.scala:159)
at sbt.HListCacheImplicits$$anon$14.write(Cache.scala:170)
at sbt.HListCacheImplicits$$anon$14.write(Cache.scala:159)
at sbt.HListCacheImplicits$$anon$14.write(Cache.scala:170)
at sbt.HListCacheImplicits$$anon$14.write(Cache.scala:159)
at sbt.HListCacheImplicits$$anon$14.write(Cache.scala:170)
at sbt.HListCacheImplicits$$anon$14.write(Cache.scala:159)
at sbt.HListCacheImplicits$$anon$14.write(Cache.scala:170)
at sbt.HListCacheImplicits$$anon$14.write(Cache.scala:159)
at sbt.Tracked$CacheHelp$$anonfun$save$1.apply(Tracked.scala:106)
at sbt.Tracked$CacheHelp$$anonfun$save$1.apply(Tracked.scala:106)
at sbt.Using.apply(Using.scala:24)
at sbt.Tracked$CacheHelp.save(Tracked.scala:106)
at sbt.Tracked$$anonfun$inputChanged$1.apply(Tracked.scala:63)
at sbt.RawCompileLike$$anonfun$cached$1.apply(RawCompileLike.scala:54)
at sbt.RawCompileLike$$anonfun$cached$1.apply(RawCompileLike.scala:39)
at sbtunidoc.Plugin$Unidoc$.apply(Plugin.scala:134)
at sbtunidoc.Plugin$$anonfun$baseCommonUnidocTasks$2.apply(Plugin.scala:27)
at sbtunidoc.Plugin$$anonfun$baseCommonUnidocTasks$2.apply(Plugin.scala:27)
at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40)
at sbt.std.Transform$$anon$4.work(System.scala:63)
at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
at sbt.Execute.work(Execute.scala:237)
at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12444#issuecomment-210821056
If it's just that simple, seems reasonable to me. Are there any downsides at all @Atry?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12444#issuecomment-210821326
**[Test build #56010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56010/consoleFull)** for PR 12444 at commit [`4c45ffc`](https://github.com/apache/spark/commit/4c45ffc0b08f9ee3645d5df376b5b14433c569bd).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12444#issuecomment-210847184
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56010/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14683][Documentation] Configure externa...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12444#issuecomment-210872358
Sounds like a great change!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org