[GitHub] rabbah commented on a change in pull request #2745: Configure jmxremote

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #2745: Configure jmxremote
URL: https://github.com/apache/incubator-openwhisk/pull/2745#discussion_r156636929
 
 

 ##########
 File path: ansible/roles/controller/tasks/deploy.yml
 ##########
 @@ -16,6 +16,20 @@
     mode: 0777
   become: "{{ logs.dir.become }}"
 
+- name: copy jmxremote password file
+  when: jmx.enabled
+  template:
+    src: "jmxremote.password.j2"
+    dest: "{{ whisk_logs_dir }}/controller{{ groups['controllers'].index(inventory_hostname) }}/jmxremote.password"
 
 Review comment:
   Hmm I understand not wanting to introduce a new directory but this seems like abusing the purpose of the logs dir. I?d favor using a conf or seperate scratch space also (maybe repurposing the nginx conf dir to be more generic is easier and cleaner). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services