[jira] [Closed] (THRIFT-3485) thrift NPM package includes whole thrift repository, is 30 megabytes

["James E. King, III (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James E. King, III closed THRIFT-3485.
--------------------------------------
       Resolution: Fixed
         Assignee: Jake Farrell
    Fix Version/s: 0.11.0

I installed thrift 0.11.0 using npm and the download was small and fast, and only the needed files were installed, so I believe this issue has been resolved.  Closing.

> thrift NPM package includes whole thrift repository, is 30 megabytes
> --------------------------------------------------------------------
>
>                 Key: THRIFT-3485
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3485
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Library
>    Affects Versions: 0.9.3
>            Reporter: Alex Zylman
>            Assignee: Jake Farrell
>            Priority: Major
>             Fix For: 0.11.0
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> The thrift npm package is as big as all of our other node dependencies combined. It currently publishes the entire thrift repository, which is ~30mb right now. As far as I can tell, it only requires lib/nodejs, which is 376k.
> I propose adding an .npmignore file. You can more info in the npm documentation: https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package
> If the package only requires lib/nodejs, we should be able to add an entry to the npmignore file for every folder (including lib), and then a negated entry for lib/nodejs. We'll also want to include everything from gitignore, because npm will no longer use that once an npmignore file is added.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)