You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/03/10 15:47:16 UTC
[GitHub] [hbase] bbeaudreault opened a new pull request #4201: HBASE-26814 Addendum: Fix spotbugs warning and clarify intent
bbeaudreault opened a new pull request #4201:
URL: https://github.com/apache/hbase/pull/4201
See discussion in https://issues.apache.org/jira/browse/HBASE-26814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell merged pull request #4201: HBASE-26814 Addendum: Fix spotbugs warning and clarify intent
Posted by GitBox <gi...@apache.org>.
apurtell merged pull request #4201:
URL: https://github.com/apache/hbase/pull/4201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #4201: HBASE-26814 Addendum: Fix spotbugs warning and clarify intent
Posted by GitBox <gi...@apache.org>.
bbeaudreault commented on pull request #4201:
URL: https://github.com/apache/hbase/pull/4201#issuecomment-1064212953
I can't seem to get spotbugs to run locally in a useful way to verify this fix. I've tried various different permutations of mvn spotbugs:spotbugs, spotbugs:check, etc. We'll see what precommit check shows, but it didn't catch the original. If someone has a one-liner I can run I'd be happy to give it a shot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4201: HBASE-26814 Addendum: Fix spotbugs warning and clarify intent
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #4201:
URL: https://github.com/apache/hbase/pull/4201#issuecomment-1064351515
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 7s | Docker mode activated. |
| -1 :x: | patch | 0m 3s | https://github.com/apache/hbase/pull/4201 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4201/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/4201 |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4201/1/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #4201: HBASE-26814 Addendum: Fix spotbugs warning and clarify intent
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #4201:
URL: https://github.com/apache/hbase/pull/4201#issuecomment-1064315657
You can look in the BlueOcean output of the General Checks to find it. The incantation looks like
```
[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1105)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1106)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1107)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1108)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1109)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1110)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1111)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1112)[](https://ci-hbase.apache.org/blue/organiz
ations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1113)[2022-03-10T13:54:26.637Z] ============================================================================
[2022-03-10T13:54:26.637Z] ============================================================================
[2022-03-10T13:54:26.637Z] spotbugs detection: branch-2.5
[2022-03-10T13:54:26.637Z] ============================================================================
[2022-03-10T13:54:26.637Z] ============================================================================
[2022-03-10T13:54:26.637Z]
[2022-03-10T13:54:26.637Z]
[2022-03-10T13:54:26.637Z] [Thu Mar 10 13:54:19 UTC 2022 INFO]: Personality: branch spotbugs
[2022-03-10T13:54:26.637Z] cd /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4196/yetus-general-check/src/hbase-server
[2022-03-10T13:54:26.637Z] /opt/maven/bin/mvn --batch-mode -Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4196/yetus-m2/hbase-branch-2.5-patch-1 --threads=2 -DHBasePatchProcess test-compile spotbugs:spotbugs -DskipTests=true > /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4196/yetus-general-check/output/branch-spotbugs-hbase-server.txt 2>&1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4201: HBASE-26814 Addendum: Fix spotbugs warning and clarify intent
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #4201:
URL: https://github.com/apache/hbase/pull/4201#issuecomment-1064352464
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | patch | 0m 3s | https://github.com/apache/hbase/pull/4201 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase/pull/4201 |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4201/1/console |
| versions | git=2.25.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #4201: HBASE-26814 Addendum: Fix spotbugs warning and clarify intent
Posted by GitBox <gi...@apache.org>.
apurtell commented on pull request #4201:
URL: https://github.com/apache/hbase/pull/4201#issuecomment-1064349546
When we cherry pick obviously spotbugs doesn't run. I do run unit tests locally, but this will vary by individual. It is interesting that the settings might be different per branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4201: HBASE-26814 Addendum: Fix spotbugs warning and clarify intent
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #4201:
URL: https://github.com/apache/hbase/pull/4201#issuecomment-1064350979
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | patch | 0m 4s | https://github.com/apache/hbase/pull/4201 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase/pull/4201 |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4201/1/console |
| versions | git=2.25.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org