You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/01 14:42:15 UTC
[GitHub] [pulsar] eolivelli commented on a change in pull request #13066: [Broker] Fix LeaderElectionService.getCurrentLeader and add support for empheralOwner in MockZooKeeper
eolivelli commented on a change in pull request #13066:
URL: https://github.com/apache/pulsar/pull/13066#discussion_r760248732
##########
File path: testmocks/src/main/java/org/apache/zookeeper/MockZooKeeper.java
##########
@@ -593,23 +618,34 @@ public Stat exists(String path, boolean watch) throws KeeperException, Interrupt
}
}
+ private Stat createStatForZNode(MockZNode zNode) {
+ return applyToStat(zNode, new Stat());
+ }
+
+ private Stat applyToStat(MockZNode zNode, Stat stat) {
Review comment:
nit: "static"
##########
File path: testmocks/src/main/java/org/apache/zookeeper/MockZooKeeper.java
##########
@@ -593,23 +618,34 @@ public Stat exists(String path, boolean watch) throws KeeperException, Interrupt
}
}
+ private Stat createStatForZNode(MockZNode zNode) {
Review comment:
nit: "static"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org