You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@skywalking.apache.org by li...@apache.org on 2024/12/12 14:54:52 UTC

(skywalking-rover) branch missing-details updated: test log

This is an automated email from the ASF dual-hosted git repository.

liuhan pushed a commit to branch missing-details
in repository https://gitbox.apache.org/repos/asf/skywalking-rover.git


The following commit(s) were added to refs/heads/missing-details by this push:
     new 0a5ea1e  test log
0a5ea1e is described below

commit 0a5ea1e9b6f8f804de1f17fec79ea3f3deece8ab
Author: mrproliu <74...@qq.com>
AuthorDate: Thu Dec 12 22:54:44 2024 +0800

    test log
---
 pkg/accesslog/collector/protocols/http1.go | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/pkg/accesslog/collector/protocols/http1.go b/pkg/accesslog/collector/protocols/http1.go
index 9cb8a27..3e424fd 100644
--- a/pkg/accesslog/collector/protocols/http1.go
+++ b/pkg/accesslog/collector/protocols/http1.go
@@ -89,9 +89,11 @@ func (p *HTTP1Protocol) Analyze(connection *PartitionConnection, _ *AnalyzeHelpe
 		}
 
 		messageType, err := reader.IdentityMessageType(buf)
+		headerTmp := make([]byte, 16)
+		buf.Peek(headerTmp)
 		log.Infof("ready to reading message type, messageType: %v, buf: %p, data id: %d, "+
-			"connection ID: %d, random ID: %d, error: %v", messageType, buf, buf.Position().DataID(),
-			metrics.ConnectionID, metrics.RandomID, err)
+			"connection ID: %d, random ID: %d, error: %v, header: %s", messageType, buf, buf.Position().DataID(),
+			metrics.ConnectionID, metrics.RandomID, err, string(headerTmp))
 		if err != nil {
 			http1Log.Debugf("failed to identity message type, %v", err)
 			if buf.SkipCurrentElement() {
@@ -213,8 +215,9 @@ func (p *HTTP1Protocol) HandleHTTPData(metrics *HTTP1Metrics, request *reader.Re
 			request.MinDataID(), response.BodyBuffer().LastSocketBuffer().DataID(), len(details))
 	}
 
-	http1Log.Debugf("found fully HTTP1 request and response, contains %d detail events , connection ID: %d, random ID: %d",
-		len(details), metrics.ConnectionID, metrics.RandomID)
+	http1Log.Infof("found fully HTTP1 request and response, contains %d detail events , connection ID: %d, random ID: %d, "+
+		"data range: %d-%d(%t)",
+		len(details), metrics.ConnectionID, metrics.RandomID, idRange.From, idRange.To, idRange.IsToBufferReadFinished)
 	originalRequest := request.Original()
 	originalResponse := response.Original()
 	// delete details(each request or response is fine because it's will delete the original buffer)