[GitHub] [superset] villebro commented on pull request #19446: feat(explore): Move chart actions into dropdown

[GitBox <gi...@apache.org>]

villebro commented on pull request #19446:
URL: https://github.com/apache/superset/pull/19446#issuecomment-1084347318


   It feels strange that the "Share chart by email" and "Embed code" are in the dropdown, while the permalink button is in the header, as I assume people will consider them similar use cases. I can see myself clicking on the action button and wondering where the permalink item is. Would one of these make sense?
   1. Making a "Share chart" submenu where we would have "Copy permalink", "Embed code" and "Share chart by email". We could potentially leave the permalink button where it is, but this way all the sharing/permalink-based functionality could at least be found in the same place
   2. Add "Copy permalink" to the Action menu. This would cause some duplication, but then it would also be located close to the other similar functionality
   3. Move the permalink button into the Action menu all together. This would have the benefit of decluttering the header even further (I'm not sure how common it is to copy permalinks)
   3. Turn the permalink button a dropdown menu with the different sharing options (copy permalink, share via email and embed code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org