You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by TypicalGitHubUser <gi...@git.apache.org> on 2017/01/16 14:51:57 UTC
[GitHub] incubator-fineract pull request #275: [MIFOSX-2114] Change assignment staff ...
GitHub user TypicalGitHubUser opened a pull request:
https://github.com/apache/incubator-fineract/pull/275
[MIFOSX-2114] Change assignment staff to group and clients in center.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TypicalGitHubUser/incubator-fineract staff-center
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fineract/pull/275.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #275
----
commit 283344e24fe02ba181370ce61a1691c1771c8b6b
Author: Ilya Andreev <an...@gmail.com>
Date: 2017-01-16T14:48:46Z
Change assignment staff to group and clients in center.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #275: [MIFOSX-2114] Change assignment staff ...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/275#discussion_r97257837
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/GroupingTypesWritePlatformServiceJpaRepositoryImpl.java ---
@@ -151,9 +151,15 @@ private CommandProcessingResult createGroupingType(final JsonCommand command, fi
validateOfficeOpeningDateisAfterGroupOrCenterOpeningDate(groupOffice, groupLevel, activationDate);
Staff staff = null;
- final Long staffId = command.longValueOfParameterNamed(GroupingTypesApiConstants.staffIdParamName);
- if (staffId != null) {
- staff = this.staffRepository.findByOfficeHierarchyWithNotFoundDetection(staffId, groupOffice.getHierarchy());
+ if ((GroupTypes.GROUP).equals(groupingType)) {
+ if (parentGroup != null) {
--- End diff --
If the Center doesn't have any staff associated then whatever staff selected while creating a group will be lost
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #275: [MIFOSX-2114] Change assignment staff ...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/275#discussion_r97257800
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java ---
@@ -243,9 +243,15 @@ public CommandProcessingResult createClient(final JsonCommand command) {
}
Staff staff = null;
- final Long staffId = command.longValueOfParameterNamed(ClientApiConstants.staffIdParamName);
- if (staffId != null) {
- staff = this.staffRepository.findByOfficeHierarchyWithNotFoundDetection(staffId, clientOffice.getHierarchy());
+ if (clientParentGroup != null) {
+ if (clientParentGroup.getParent() != null) {
+ staff = clientParentGroup.getParent().getStaff();
--- End diff --
If the group doesn't have any staff associated then whatever staff selected while creating a client will be lost
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---