You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Lewuathe <gi...@git.apache.org> on 2015/01/21 14:09:06 UTC
[GitHub] storm pull request: [STORM-630] Support for Clojure 1.6.0
GitHub user Lewuathe opened a pull request:
https://github.com/apache/storm/pull/390
[STORM-630] Support for Clojure 1.6.0
Through upgrading clojure 1.6.0, there are name space conflicts in `zip-contains-dir?`. Renamed it.
It looks there is no other dependencies of `some?` function and a topology, `ExclamationTopology` seems fine with
on my test cluster. If there is any other concern about upgrading clojure, please let me know.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Lewuathe/storm upgrade-clojure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/390.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #390
----
commit dd92c0d87e589b345ae1167e7318e43ba44556bf
Author: lewuathe <le...@me.com>
Date: 2015-01-21T13:04:14Z
[STORM-630] Support for Clojure 1.6.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-630] Support for Clojure 1.6.0
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-630] Support for Clojure 1.6.0
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/390#issuecomment-71053295
+1 the code looks fine to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---