[GitHub] [lucene-solr] murblanc commented on a change in pull request #2438: SOLR-14928: add exponential backoff for distributed cluster state updates

[GitBox <gi...@apache.org>]

murblanc commented on a change in pull request #2438:
URL: https://github.com/apache/lucene-solr/pull/2438#discussion_r584328989



##########
File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java
##########
@@ -111,7 +111,7 @@
       DocCollection.PER_REPLICA_STATE, null,
       ZkStateReader.PULL_REPLICAS, "0"));
 
-  protected static final Random RANDOM;
+  public static final Random RANDOM;

Review comment:
       This variable was moved here as part of a refactoring, see [PR 2390](https://github.com/apache/lucene-solr/pull/2390).
   When introduced in [2014 in OverseerCollectionMessageHandler](https://github.com/apache/lucene-solr/commit/3f999895448c9524c77ff33b801f43cfb6f8b8bd#diff-942546903f5862bde980b5392f8a4cf99e9b16fe1d48f7d1a0e61661dc36a173R167) this variable already had that uppercase name.
   
   Do you want me to lowercase it? Likely matter of personal taste, but to me it seems ok uppercase. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org