You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by mattwiller <gi...@git.apache.org> on 2015/10/12 22:09:52 UTC
[GitHub] thrift pull request: THRIFT-3380 nodejs Fix broken transport and p...
GitHub user mattwiller opened a pull request:
https://github.com/apache/thrift/pull/651
THRIFT-3380 nodejs Fix broken transport and protocol requires
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattwiller/thrift package_json_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/651.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #651
----
commit 811a33320e3421f06f29ef2cae20eb917da4ae95
Author: Matt Willer <mw...@box.com>
Date: 2015-10-12T20:06:23Z
THRIFT-3380 nodejs Fix broken transport and protocol requires
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3380 nodejs Fix broken transport and p...
Posted by bufferoverflow <gi...@git.apache.org>.
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/651#issuecomment-147880525
This change is needed on top of the existing PR to make the nodejs testsuite up and running again:
```
diff --git a/lib/nodejs/test/testAll.sh b/lib/nodejs/test/testAll.sh
index 38b284a..417411b 100755
--- a/lib/nodejs/test/testAll.sh
+++ b/lib/nodejs/test/testAll.sh
@@ -23,8 +23,8 @@ fi
DIR="$( cd "$( dirname "$0" )" && pwd )"
-ISTANBUL="$DIR/../../../node_modules/istanbul/lib/cli.js"
-RUNBROWSER="$DIR/../../../node_modules/run-browser/bin/cli.js"
+ISTANBUL="$DIR/../node_modules/istanbul/lib/cli.js"
+RUNBROWSER="$DIR/../node_modules/run-browser/bin/cli.js"
REPORT_PREFIX="${DIR}/../coverage/report"
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #651: THRIFT-3380 nodejs Fix broken transport and protocol requ...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/651
@jfarrell this was marked Won't Fix in Jira. This PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #651: THRIFT-3380 nodejs Fix broken transport and protoc...
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/651
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---