You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2011/06/14 17:03:47 UTC

[jira] [Commented] (HADOOP-7390) VersionInfo not generated properly in git after unsplit

    [ https://issues.apache.org/jira/browse/HADOOP-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049219#comment-13049219 ] 

Hadoop QA commented on HADOOP-7390:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12482556/hadoop-7390.txt
  against trunk revision 1135333.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/626//console

This message is automatically generated.

> VersionInfo not generated properly in git after unsplit
> -------------------------------------------------------
>
>                 Key: HADOOP-7390
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7390
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>            Reporter: Thomas Graves
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-7390.txt
>
>
> The version information generated during the build of common when running from git has revision and branch Unknown. I believe this started after the unsplit:
> @HadoopVersionAnnotation(version="0.22.0-SNAPSHOT", revision="Unknown", branch="Unknown",
>                          user="tgraves", date="Tue Jun 14 13:39:10 UTC 2011", url="file:///home/tgraves/git/hadoop-common/common",
>                          srcChecksum="0f78ea668971fe51e7ebf4f97f84eed2")
> The ./src/saveVersion.sh script which generates the package-info.java file with the version info looks for the presence of .git directory and that is now a level up instead of in the common directory.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira