You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Fei Hui (JIRA)" <ji...@apache.org> on 2017/03/05 06:18:32 UTC

[jira] [Assigned] (TEZ-3649) AsyncHttpConnection should add StopWatch start

     [ https://issues.apache.org/jira/browse/TEZ-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fei Hui reassigned TEZ-3649:
----------------------------

    Assignee: Fei Hui

> AsyncHttpConnection should add StopWatch start
> ----------------------------------------------
>
>                 Key: TEZ-3649
>                 URL: https://issues.apache.org/jira/browse/TEZ-3649
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Fei Hui
>            Assignee: Fei Hui
>
> {code:title=AsyncHttpConnection.java|borderStyle=solid}
>   public void validate() throws IOException {
>     // get the shuffle version
>     if (!ShuffleHeader.DEFAULT_HTTP_HEADER_NAME
>         .equals(response.getHeader(ShuffleHeader.HTTP_HEADER_NAME))
>         || !ShuffleHeader.DEFAULT_HTTP_HEADER_VERSION
>         .equals(response.getHeader(ShuffleHeader.HTTP_HEADER_VERSION))) {
>       throw new IOException("Incompatible shuffle response version");
>     }
>     // get the replyHash which is HMac of the encHash we sent to the server
>     String replyHash = response.getHeader(SecureShuffleUtils.HTTP_HEADER_REPLY_URL_HASH);
>     if (replyHash == null) {
>       throw new IOException("security validation of TT Map output failed");
>     }
>     LOG.debug("url={};encHash={};replyHash={}", msgToEncode, encHash, replyHash);
>     // verify that replyHash is HMac of encHash
>     SecureShuffleUtils.verifyReply(replyHash, encHash, jobTokenSecretMgr);
>     //Following log statement will be used by tez-tool perf-analyzer for mapping attempt to NM host
>     LOG.info("for url={} sent hash and receievd reply {} ms", url, stopWatch.now(TimeUnit.MILLISECONDS));
>   }
> {code}
> It uses stopWatch.now, but never starts it. we should start it at the beginning of this function



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)