You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by victornoel <gi...@git.apache.org> on 2015/05/18 12:57:07 UTC
[GitHub] camel pull request: Maven plugins: m2e compatibility
GitHub user victornoel opened a pull request:
https://github.com/apache/camel/pull/518
Maven plugins: m2e compatibility
Hi, here is a PR following a discussion on the mailing list.
The idea is that currently, the camel-package-maven-plugin does not integrate very well with Eclipse: when the goals (listed below) are triggered, they trigger a rebuild of the project which triggers the goals and so on indefinitely.
The m2e project provides guidelines to improve maven plugins compatibility with Eclipse in the following page: http://eclipse.org/m2e/documentation/m2e-making-maven-plugins-compat.html
I thus propose these (simple) changes for the (listed below) goals of camel-package-maven-plugin.
If I understood well they are the only ones really meant to be used by people developing components.
- Uses BuildContext to support m2e and improve user experience in Eclipse
- Only trigger execution when input has changed
- Notify eclipse of change of output
- Only support the following goals in camel-package-maven-plugin
- generate-components-list
- generate-dataformats-list
- generate-languages-list
- prepare-components
I also had to increase the required version for one dependency (only used in the maven plugins normally) because it was needed by the added dependency providing the BuildContext.
Thank you very much, I hope this will be accepted, I'm available to improve anything in there.
If I understood well @davsclaus you are taking care of the maven plugins, if you could give your opinion about that PR and merge it when it's done, it would be great :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/victornoel/camel camel-maven-m2e-compat
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/518.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #518
----
commit b0c2461b3b9da7673783c349e588cf556705634d
Author: Victor Noël <vi...@linagora.com>
Date: 2015-05-18T10:43:04Z
Maven plugins: m2e compatibility
- Uses BuildContext to support m2e and improve user experience in Eclipse
- Only trigger execution when input has changed
- Notify eclipse of change of output
- Only support the following goals in camel-package-maven-plugin (the others are not really meant to be used by non-Camel developers)
- generate-components-list
- generate-dataformats-list
- generate-languages-list
- prepare-components
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] camel pull request: Maven plugins: m2e compatibility
Posted by victornoel <gi...@git.apache.org>.
Github user victornoel closed the pull request at:
https://github.com/apache/camel/pull/518
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---