You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/12 11:34:22 UTC
[GitHub] [maven] cstamas opened a new pull request, #956: [MNG-7666] Update default binding and lifecycle plugin versions
cstamas opened a new pull request, #956:
URL: https://github.com/apache/maven/pull/956
Finally use 3.x plugins for all.
---
https://issues.apache.org/jira/browse/MNG-7666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #956: [MNG-7666] Update default binding and lifecycle plugin versions
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #956:
URL: https://github.com/apache/maven/pull/956#issuecomment-1383715547
On jenkins local repo is not set for IT tests .... looks like somewhen was used ...
https://github.com/apache/maven/blob/master/Jenkinsfile#L91-L104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas merged pull request #956: [MNG-7666] Update default binding and lifecycle plugin versions
Posted by GitBox <gi...@apache.org>.
cstamas merged PR #956:
URL: https://github.com/apache/maven/pull/956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #956: [MNG-7666] Update default binding and lifecycle plugin versions
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #956:
URL: https://github.com/apache/maven/pull/956#issuecomment-1380306097
Reason of IT failure:
```
Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact org.apache.maven.plugins:maven-surefire-plugin:jar:3.0.0-M8 in central (file:target/null)
```
Basically this issue https://issues.apache.org/jira/browse/MNG-7667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #956: [MNG-7666] Update default binding and lifecycle plugin versions
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #956:
URL: https://github.com/apache/maven/pull/956#discussion_r1068026566
##########
maven-core/src/main/java/org/apache/maven/lifecycle/providers/WrapperLifecycleProvider.java:
##########
@@ -33,7 +33,7 @@ public final class WrapperLifecycleProvider extends AbstractLifecycleProvider {
// START SNIPPET: wrapper
private static final String[] PHASES = {"wrapper"};
- private static final String[] BINDINGS = {"wrapper", "org.apache.maven.plugins:maven-wrapper-plugin:3.1.0:wrapper"};
+ private static final String[] BINDINGS = {"wrapper", "org.apache.maven.plugins:maven-wrapper-plugin:3.1.1:wrapper"};
Review Comment:
Here as sell
##########
maven-core/src/main/java/org/apache/maven/lifecycle/providers/SiteLifecycleProvider.java:
##########
@@ -34,8 +34,8 @@ public final class SiteLifecycleProvider extends AbstractLifecycleProvider {
private static final String[] PHASES = {"pre-site", "site", "post-site", "site-deploy"};
private static final String[] BINDINGS = {
- "site", "org.apache.maven.plugins:maven-site-plugin:3.9.1:site",
- "site-deploy", "org.apache.maven.plugins:maven-site-plugin:3.9.1:deploy"
+ "site", "org.apache.maven.plugins:maven-site-plugin:3.12.1:site",
+ "site-deploy", "org.apache.maven.plugins:maven-site-plugin:3.12.1:deploy"
};
Review Comment:
I think this needs to move out like in CleanLifecycleProvider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #956: [MNG-7666] Update default binding and lifecycle plugin versions
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #956:
URL: https://github.com/apache/maven/pull/956#issuecomment-1383690348
Hm, more IT failures: by https://github.com/apache/maven-integration-testing/pull/230 the org.apache.maven.plugin-tools:maven-plugin-tools-ant:jar:3.7.1 is NOT pulled in...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on a diff in pull request #956: [MNG-7666] Update default binding and lifecycle plugin versions
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #956:
URL: https://github.com/apache/maven/pull/956#discussion_r1068060689
##########
maven-core/src/main/java/org/apache/maven/lifecycle/providers/SiteLifecycleProvider.java:
##########
@@ -34,8 +34,8 @@ public final class SiteLifecycleProvider extends AbstractLifecycleProvider {
private static final String[] PHASES = {"pre-site", "site", "post-site", "site-deploy"};
private static final String[] BINDINGS = {
- "site", "org.apache.maven.plugins:maven-site-plugin:3.9.1:site",
- "site-deploy", "org.apache.maven.plugins:maven-site-plugin:3.9.1:deploy"
+ "site", "org.apache.maven.plugins:maven-site-plugin:3.12.1:site",
+ "site-deploy", "org.apache.maven.plugins:maven-site-plugin:3.12.1:deploy"
};
Review Comment:
done
##########
maven-core/src/main/java/org/apache/maven/lifecycle/providers/WrapperLifecycleProvider.java:
##########
@@ -33,7 +33,7 @@ public final class WrapperLifecycleProvider extends AbstractLifecycleProvider {
// START SNIPPET: wrapper
private static final String[] PHASES = {"wrapper"};
- private static final String[] BINDINGS = {"wrapper", "org.apache.maven.plugins:maven-wrapper-plugin:3.1.0:wrapper"};
+ private static final String[] BINDINGS = {"wrapper", "org.apache.maven.plugins:maven-wrapper-plugin:3.1.1:wrapper"};
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #956: [MNG-7666] Update default binding and lifecycle plugin versions
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #956:
URL: https://github.com/apache/maven/pull/956#issuecomment-1380253700
Also lowered the _ID constants visibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org