You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/06/23 00:37:20 UTC
[kudu-CR](gh-pages) Control how content is cached on the Kudu web site
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3462
to review the following change.
Change subject: Control how content is cached on the Kudu web site
......................................................................
Control how content is cached on the Kudu web site
Change-Id: I08619464d8d458582282044a7db685f8fbbca483
---
A .htaccess
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/3462/1
--
To view, visit http://gerrit.cloudera.org:8080/3462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08619464d8d458582282044a7db685f8fbbca483
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) Control how content is cached on the Kudu web site
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Control how content is cached on the Kudu web site
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3462/1/.htaccess
File .htaccess:
Line 1: # Don't cache content or styles / scripts served by us.
I forget, do we serve our own bootstrap/etc? or use a cdn?
Line 5: Header unset ETag
why not use etag based caching?
--
To view, visit http://gerrit.cloudera.org:8080/3462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08619464d8d458582282044a7db685f8fbbca483
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Control how content is cached on the Kudu web site
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Control how content is cached on the Kudu web site
......................................................................
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08619464d8d458582282044a7db685f8fbbca483
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR](gh-pages) Control how content is cached on the Kudu web site
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Control how content is cached on the Kudu web site
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3462/1/.htaccess
File .htaccess:
Line 1: # Don't cache content or styles / scripts served by us.
> I forget, do we serve our own bootstrap/etc? or use a cdn?
Mostly CDN, but it's a mix. We should probably try to get more from a CDN. e.g. right now we serve bootstrap, but jquery is on a CDN. If we had our own CDN, we could also put our own (versioned) files up there and have it cache the files indefinitely.
Line 5: Header unset ETag
> why not use etag based caching?
ETags are not distributed; different servers will give different ETags for the same content. Since the upstream site appears to have mirrors (based on nslookup) then I don't think ETags will work. See also https://developer.yahoo.com/performance/rules.html#etags=
However I didn't do a thorough investigation of how ASF load balancing is set up.
--
To view, visit http://gerrit.cloudera.org:8080/3462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08619464d8d458582282044a7db685f8fbbca483
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Control how content is cached on the Kudu web site
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Control how content is cached on the Kudu web site
......................................................................
Control how content is cached on the Kudu web site
Change-Id: I08619464d8d458582282044a7db685f8fbbca483
Reviewed-on: http://gerrit.cloudera.org:8080/3462
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
A .htaccess
1 file changed, 18 insertions(+), 0 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/3462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08619464d8d458582282044a7db685f8fbbca483
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>