[GitHub] [cordova-plugin-media] GedasGa commented on a change in pull request #234: Convert jshint to eslint

[GitBox <gi...@apache.org>]

GedasGa commented on a change in pull request #234: Convert jshint to eslint
URL: https://github.com/apache/cordova-plugin-media/pull/234#discussion_r294704993
 
 

 ##########
 File path: tests/tests.js
 ##########
 @@ -1087,20 +1084,14 @@ exports.defineManualTests = function (contentEl, createActionButton) {
     createActionButton('Seek To', function () {
         seekAudio('to');
     }, 'seekToBtn');
-    createActionButton('Set volume', function() {
+    createActionButton('Set volume', function () {
         setVolume();
     }, 'setVolumeBtn');
-    //get Special path to record if iOS || Blackberry
-    if (cordova.platformId === 'ios')
-        getRecordSrc();
-    else if (cordova.platformId === 'blackberry')
-        getRecordSrcBB();
-    else if (cordova.platformId === 'windows' || cordova.platformId === 'windows8')
-        getRecordSrcWin();
-
-    //testing process and details
-    function addItemToList(_list, _text)
-    {
+    // get Special path to record if iOS || Blackberry
+    if (cordova.platformId === 'ios') { getRecordSrc(); } else if (cordova.platformId === 'blackberry') { getRecordSrcBB(); } else if (cordova.platformId === 'windows' || cordova.platformId === 'windows8') { getRecordSrcWin(); }
 
 Review comment:
   In this PR, I was only trying to convert to `eslint` with bare minimum changes, but thanks the suggestion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org