You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by resmo <gi...@git.apache.org> on 2016/11/22 14:30:14 UTC

[GitHub] cloudstack pull request #1769: tools: fix Dockerfile

GitHub user resmo opened a pull request:

    https://github.com/apache/cloudstack/pull/1769

    tools: fix Dockerfile

    Build a docker image did not work anymore for various reasons. This is how I fixed it

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/resmo/cloudstack fix/dockerfile

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1769.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1769
    
----
commit aba2b2bd2c80d16e069dc445d83fe13ab7295667
Author: Rene Moser <re...@apache.org>
Date:   2016-11-22T14:26:44Z

    tools: fix Dockerfile

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Posted by wido <gi...@git.apache.org>.

Github user wido commented on the issue:

    https://github.com/apache/cloudstack/pull/1769
  
    Changes look good to me, but waiting for @pdion891 to tell us more :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Posted by pdion891 <gi...@git.apache.org>.

Github user pdion891 commented on the issue:

    https://github.com/apache/cloudstack/pull/1769
  
    ok, I'll update the PR and merge it I think the PR go all required LGTM. I'll confirmed with John, in case he is in a code freeze period.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Posted by pdion891 <gi...@git.apache.org>.

Github user pdion891 commented on the issue:

    https://github.com/apache/cloudstack/pull/1769
  
    @resmo  could you do a PR on top of #1435 ? or this have to be merged first? so we can get your chances and some of mine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Posted by pdion891 <gi...@git.apache.org>.

Github user pdion891 commented on the issue:

    https://github.com/apache/cloudstack/pull/1769
  
    Hi @resmo,  I've made some changes on the Docker file so it might not be possible to merge this PR in the current state.
    
    Thanks! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Posted by pdion891 <gi...@git.apache.org>.

Github user pdion891 commented on the issue:

    https://github.com/apache/cloudstack/pull/1769
  
    So, should we go forward and merge #1435 + #1769  to master?
    I might just need to rebase and update version number of the current commit.
    
    With those 2 PR, we would have master back online on dockerhub so we can get an updater docker image for the simulator!
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Posted by rhtyd <gi...@git.apache.org>.

Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1769
  
    @resmo now that PR by @pdion891 is merge, can this be closed? Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Posted by rhtyd <gi...@git.apache.org>.

Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1769
  
    LGTM. @pdion891 would you like to review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Posted by pdion891 <gi...@git.apache.org>.

Github user pdion891 commented on the issue:

    https://github.com/apache/cloudstack/pull/1769
  
    Could you look if it conflict with #1435 ?  Because I made a pull request to automatically increment version in docker file when changing release of master via ```tools/build/setnextversion.sh```.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Posted by resmo <gi...@git.apache.org>.

Github user resmo commented on the issue:

    https://github.com/apache/cloudstack/pull/1769
  
    I didn't test #1435 yet, but code looks good. The only difference I see is:
    ~~~
    pip install cryptography --force-reinstall
    ~~~
    
    And I used the mysql connector from MySQL.com but would prefer to take it from distribution (as in #1435) 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Posted by resmo <gi...@git.apache.org>.

Github user resmo commented on the issue:

    https://github.com/apache/cloudstack/pull/1769
  
    ok, np closing for now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---