You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/05 01:09:54 UTC

[GitHub] [shardingsphere] natehuangting commented on pull request #20771: add resource bug

natehuangting commented on PR #20771:
URL: https://github.com/apache/shardingsphere/pull/20771#issuecomment-1236457656

   > @natehuangting Hi, this pr has some problem, The createNewDataSource method are return an incremental data source.
   
   Thanks! But I think this modification is more intuitive and convenient, and there are less unnecessary calculations. Maybe we can refactor the method name?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org