You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/17 04:15:02 UTC
[GitHub] [spark] attilapiros commented on a change in pull request #26869:
[SPARK-30235][CORE] Switching off host local disk reading of shuffle blocks
in case of useOldFetchProtocol
attilapiros commented on a change in pull request #26869: [SPARK-30235][CORE] Switching off host local disk reading of shuffle blocks in case of useOldFetchProtocol
URL: https://github.com/apache/spark/pull/26869#discussion_r358589382
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1097,9 +1097,9 @@ package object config {
private[spark] val SHUFFLE_HOST_LOCAL_DISK_READING_ENABLED =
ConfigBuilder("spark.shuffle.readHostLocalDisk.enabled")
- .doc("If enabled, shuffle blocks requested from those block managers which are running on " +
- "the same host are read from the disk directly instead of being fetched as remote blocks " +
- "over the network.")
+ .doc("If enabled (and `spark.shuffle.useOldFetchProtocol` is disabled), shuffle blocks " +
Review comment:
Transforming the first part to string interpolation has not been forgotten.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org