You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/07/18 18:46:02 UTC
[GitHub] [tinkerpop] kenhuuu opened a new pull request, #1761: TINKERPOP-2769: Add server response for tasks that never run because of timeout.
kenhuuu opened a new pull request, #1761:
URL: https://github.com/apache/tinkerpop/pull/1761
Add handling for situations where a task that is supposed to respond to the client is cancelled before it runs because it times out.
Fixes https://issues.apache.org/jira/browse/TINKERPOP-2769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #1761: TINKERPOP-2769: Add server response for tasks that never run because of timeout.
Posted by GitBox <gi...@apache.org>.
spmallette merged PR #1761:
URL: https://github.com/apache/tinkerpop/pull/1761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #1761: TINKERPOP-2769: Add server response for tasks that never run because of timeout.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1761:
URL: https://github.com/apache/tinkerpop/pull/1761#issuecomment-1188138589
# [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1761](https://codecov.io/gh/apache/tinkerpop/pull/1761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bb81ef1) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/8c1f0ea0a3a2721b54b5e21f4ef78b866b5bdddb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c1f0ea) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.5-dev #1761 +/- ##
===========================================
+ Coverage 63.48% 63.58% +0.09%
===========================================
Files 23 23
Lines 3640 3636 -4
===========================================
+ Hits 2311 2312 +1
+ Misses 1150 1145 -5
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [gremlin-go/driver/connection.go](https://codecov.io/gh/apache/tinkerpop/pull/1761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvY29ubmVjdGlvbi5nbw==) | `77.77% <0.00%> (-2.23%)` | :arrow_down: |
| [gremlin-go/driver/protocol.go](https://codecov.io/gh/apache/tinkerpop/pull/1761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvcHJvdG9jb2wuZ28=) | `66.40% <0.00%> (+1.79%)` | :arrow_up: |
| [gremlin-go/driver/gorillaTransporter.go](https://codecov.io/gh/apache/tinkerpop/pull/1761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZ29yaWxsYVRyYW5zcG9ydGVyLmdv) | `66.98% <0.00%> (+2.43%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8c1f0ea...bb81ef1](https://codecov.io/gh/apache/tinkerpop/pull/1761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1761: TINKERPOP-2769: Add server response for tasks that never run because of timeout.
Posted by GitBox <gi...@apache.org>.
spmallette commented on PR #1761:
URL: https://github.com/apache/tinkerpop/pull/1761#issuecomment-1201104056
Could you please add a CHANGELOG entry and do a quick review for `final` declarations where needed? nice looking tests, so other than that, this one looks ok i think. i may want to give it a second look though before merging as this area of code with timeouts is always tricky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] jroimartin commented on pull request #1761: TINKERPOP-2769: Add server response for tasks that never run because of timeout.
Posted by GitBox <gi...@apache.org>.
jroimartin commented on PR #1761:
URL: https://github.com/apache/tinkerpop/pull/1761#issuecomment-1192356654
@kenhuuu I tested the PR and I can confirm that both the gremlin-go and the gremlin-python reproducers are not able to trigger the issue anymore. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org