You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Aurelien DE FANTI <a_...@yahoo.fr> on 2012/11/10 02:15:20 UTC

Review Request: maven : sort dependencies version by alphabetical order

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8001/
-----------------------------------------------------------

Review request for cloudstack.


Summary (updated)
-----------------

maven : sort dependencies version by alphabetical order


Description (updated)
-------

Maven : sort dependencies version by alphabetical order.
This is the first commit for simplifying maven dependencies future maintenance.


Diffs (updated)
-----

  pom.xml 08f61f5 

Diff: https://reviews.apache.org/r/8001/diff/


Testing (updated)
-------

mvn clean install


Thanks,

Aurelien DE FANTI


Re: Review Request: maven : sort dependencies version by alphabetical order

Posted by Aurelien DE FANTI <a_...@yahoo.fr>.

> On Nov. 10, 2012, 2:48 p.m., Prasanna Santhanam wrote:
> > Happy to push this since it's only a reorder. But apart from easier maintenance is there a good maven practice or reason for doing this?

For me, when dependencies version are sorted, you can more easily know what dependencies are used by project.
I don't know if it's a good maven practice but I encounter this in my professional projects or in some apache projects (like camel or servicemix).


- Aurelien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8001/#review13323
-----------------------------------------------------------


On Nov. 10, 2012, 1:15 a.m., Aurelien DE FANTI wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8001/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 1:15 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Maven : sort dependencies version by alphabetical order.
> This is the first commit for simplifying maven dependencies future maintenance.
> 
> 
> Diffs
> -----
> 
>   pom.xml 08f61f5 
> 
> Diff: https://reviews.apache.org/r/8001/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> 
> Thanks,
> 
> Aurelien DE FANTI
> 
>


Re: Review Request: maven : sort dependencies version by alphabetical order

Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8001/#review13323
-----------------------------------------------------------


Happy to push this since it's only a reorder. But apart from easier maintenance is there a good maven practice or reason for doing this?

- Prasanna Santhanam


On Nov. 10, 2012, 1:15 a.m., Aurelien DE FANTI wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8001/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 1:15 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Maven : sort dependencies version by alphabetical order.
> This is the first commit for simplifying maven dependencies future maintenance.
> 
> 
> Diffs
> -----
> 
>   pom.xml 08f61f5 
> 
> Diff: https://reviews.apache.org/r/8001/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> 
> Thanks,
> 
> Aurelien DE FANTI
> 
>


Re: Review Request: maven : sort dependencies version by alphabetical order

Posted by Rohit Yadav <ro...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8001/#review13327
-----------------------------------------------------------

Ship it!


Looks fine, ship it!

- Rohit Yadav


On Nov. 10, 2012, 1:15 a.m., Aurelien DE FANTI wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8001/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 1:15 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Maven : sort dependencies version by alphabetical order.
> This is the first commit for simplifying maven dependencies future maintenance.
> 
> 
> Diffs
> -----
> 
>   pom.xml 08f61f5 
> 
> Diff: https://reviews.apache.org/r/8001/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> 
> Thanks,
> 
> Aurelien DE FANTI
> 
>