You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/15 09:00:16 UTC

[GitHub] TisonKun edited a comment on issue #6816: [FLINK-10527] Cleanup constant isNewMode in YarnTestBase

TisonKun edited a comment on issue #6816: [FLINK-10527] Cleanup constant isNewMode in YarnTestBase
URL: https://github.com/apache/flink/pull/6816#issuecomment-429763575
 
 
   Hi @yanghua , I see your last commit and think it is still use the legacy mode. (Since you start an actor system and use `ActorGateway` instead of using FLIP-6 components.)
   
   To minimize this pull request as its title "Cleanup constant isNewMode in YarnTestBase", I propose to retain the clean up in `YARNSessionFIFOITCase`, simply remove `isNewMode` and add `@Ignore` to `YARNHighAvailabilityITCase`, `YARNSessionCapacitySchedulerITCase#testClientStartup` and `YARNSessionCapacitySchedulerITCase#testTaskManagerFailure`. Meanwhile, raising a JIRA about port those tests.   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services