You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by millayr <gi...@git.apache.org> on 2016/10/18 20:16:45 UTC
[GitHub] couchdb-fauxton pull request #789: 3045 Replace safeURLName in code
GitHub user millayr opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/789
3045 Replace safeURLName in code
**Task description from ticket:**
We have a still some usages of safeURLName where we manually slice of the _design prefix for design docs. Later we glue the prefix on again. We have a helper function that handles that already, which is also available in the utils.js file.
Task: find appearances of safeURLName with code search, understand how it is used, remove custom safeURLName shenanigans with their design doc handling and replace it with other helper function.
**Change Description**
I located two places where it made sense to update safeURLName to getSafeIdForDoc. While there were several places we use safeURLName in Fauxton, not all of them needed to be changed. I'm open to feedback, however, if others feel as though I missed some instances where it did make sense to update.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/millayr/couchdb-fauxton 3045-replace-safeURLName-in-code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/789.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #789
----
commit 74ffea12742397ed60f85db04ec7f34bc57f2ee5
Author: Ryan Millay <ry...@gmail.com>
Date: 2016-10-18T19:51:01Z
replacing safeURLName with getSafeIdForDoc where appropriate
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #789: 3045 Replace safeURLName in code
Posted by millayr <gi...@git.apache.org>.
GitHub user millayr reopened a pull request:
https://github.com/apache/couchdb-fauxton/pull/789
3045 Replace safeURLName in code
**Task description from ticket:**
We have a still some usages of safeURLName where we manually slice of the _design prefix for design docs. Later we glue the prefix on again. We have a helper function that handles that already, which is also available in the utils.js file.
Task: find appearances of safeURLName with code search, understand how it is used, remove custom safeURLName shenanigans with their design doc handling and replace it with other helper function.
**Change Description**
I located two places where it made sense to update safeURLName to getSafeIdForDoc. While there were several places we use safeURLName in Fauxton, not all of them needed to be changed. I'm open to feedback, however, if others feel as though I missed some instances where it did make sense to update.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/millayr/couchdb-fauxton 3045-replace-safeURLName-in-code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/789.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #789
----
commit 74ffea12742397ed60f85db04ec7f34bc57f2ee5
Author: Ryan Millay <ry...@gmail.com>
Date: 2016-10-18T19:51:01Z
replacing safeURLName with getSafeIdForDoc where appropriate
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #789: 3045 Replace safeURLName in code
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/789
I think all our encoding fixes supercede this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #789: 3045 Replace safeURLName in code
Posted by millayr <gi...@git.apache.org>.
GitHub user millayr reopened a pull request:
https://github.com/apache/couchdb-fauxton/pull/789
3045 Replace safeURLName in code
**Task description from ticket:**
We have a still some usages of safeURLName where we manually slice of the _design prefix for design docs. Later we glue the prefix on again. We have a helper function that handles that already, which is also available in the utils.js file.
Task: find appearances of safeURLName with code search, understand how it is used, remove custom safeURLName shenanigans with their design doc handling and replace it with other helper function.
**Change Description**
I located two places where it made sense to update safeURLName to getSafeIdForDoc. While there were several places we use safeURLName in Fauxton, not all of them needed to be changed. I'm open to feedback, however, if others feel as though I missed some instances where it did make sense to update.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/millayr/couchdb-fauxton 3045-replace-safeURLName-in-code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/789.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #789
----
commit 74ffea12742397ed60f85db04ec7f34bc57f2ee5
Author: Ryan Millay <ry...@gmail.com>
Date: 2016-10-18T19:51:01Z
replacing safeURLName with getSafeIdForDoc where appropriate
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #789: 3045 Replace safeURLName in code
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/789
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #789: 3045 Replace safeURLName in code
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/789
tests are red @millayr - can you see why?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #789: 3045 Replace safeURLName in code
Posted by millayr <gi...@git.apache.org>.
Github user millayr closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/789
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #789: 3045 Replace safeURLName in code
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/789
tests are red
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #789: 3045 Replace safeURLName in code
Posted by millayr <gi...@git.apache.org>.
Github user millayr closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/789
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---