You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/27 02:55:29 UTC

[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #13297: [DistSQL] Support table level `queryWithCipherColumn` configuration

RaigorJiang commented on a change in pull request #13297:
URL: https://github.com/apache/shardingsphere/pull/13297#discussion_r737063697



##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-distsql/shardingsphere-encrypt-distsql-parser/src/main/antlr4/imports/encrypt/RDLStatement.g4
##########
@@ -78,3 +78,7 @@ algorithmProperties
 algorithmProperty
     : key=(IDENTIFIER | STRING) EQ value=(NUMBER | INT | STRING)
     ;
+    
+queryWithCipherColumn
+    : 'true' | 'false'

Review comment:
       1. Can the value of queryWithCipherColumn only support lowercase?
   2. Does this value have to be quoted?
   Can it be compatible with more cases like other inputs?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org