You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Николай Ижиков <ni...@gmail.com> on 2017/05/26 10:09:12 UTC
DiscoverySpi#setDataExchange returns concrete implementation
Hello, guys.
public interface DiscoverySpi extends IgniteSpi {
....
TcpDiscoverySpi setDataExchange(DiscoverySpiDataExchange var1);
TcpDiscoverySpi setMetricsProvider(DiscoveryMetricsProvider var1);
...
}
Two methods of DiscoverySpi returns concrete implementation.
I think we should return interface, not implementation from this methods
Or why we need an interface?
I can provide simple patch to fix this issue.
--
Nikolay Izhikov
NIzhikov.dev@gmail.com
Re: DiscoverySpi#setDataExchange returns concrete implementation
Posted by Yakov Zhdanov <yz...@apache.org>.
yes
--Yakov
2017-05-29 17:30 GMT+03:00 Николай Ижиков <ni...@gmail.com>:
> Thanks Yakov.
>
> I moved IGNITE-5321 to resolved state.
> Is that right?
>
> 2017-05-29 17:24 GMT+03:00 Yakov Zhdanov <yz...@apache.org>:
>
> > Merged. Thanks for contribution, Nick. Please also see my edits.
> >
> > --Yakov
> >
> > 2017-05-28 19:29 GMT+03:00 Николай Ижиков <ni...@gmail.com>:
> >
> > > Hello. Here is pull request for this issue:
> > >
> > > https://github.com/apache/ignite/pull/2022
> > >
> > > 2017-05-26 13:16 GMT+03:00 Yakov Zhdanov <yz...@apache.org>:
> > >
> > > > Hi Nick! Good catch. Please go ahead and submit a patch.
> > > >
> > > > --Yakov
> > > >
> > > > 2017-05-26 13:09 GMT+03:00 Николай Ижиков <ni...@gmail.com>:
> > > >
> > > > > Hello, guys.
> > > > >
> > > > > public interface DiscoverySpi extends IgniteSpi {
> > > > > ....
> > > > > TcpDiscoverySpi setDataExchange(DiscoverySpiDataExchange
> var1);
> > > > >
> > > > > TcpDiscoverySpi setMetricsProvider(DiscoveryMetricsProvider
> > var1);
> > > > > ...
> > > > > }
> > > > >
> > > > > Two methods of DiscoverySpi returns concrete implementation.
> > > > > I think we should return interface, not implementation from this
> > > methods
> > > > > Or why we need an interface?
> > > > >
> > > > > I can provide simple patch to fix this issue.
> > > > >
> > > > > --
> > > > > Nikolay Izhikov
> > > > > NIzhikov.dev@gmail.com
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Nikolay Izhikov
> > > NIzhikov.dev@gmail.com
> > >
> >
>
>
>
> --
> Nikolay Izhikov
> NIzhikov.dev@gmail.com
>
Re: DiscoverySpi#setDataExchange returns concrete implementation
Posted by Николай Ижиков <ni...@gmail.com>.
Thanks Yakov.
I moved IGNITE-5321 to resolved state.
Is that right?
2017-05-29 17:24 GMT+03:00 Yakov Zhdanov <yz...@apache.org>:
> Merged. Thanks for contribution, Nick. Please also see my edits.
>
> --Yakov
>
> 2017-05-28 19:29 GMT+03:00 Николай Ижиков <ni...@gmail.com>:
>
> > Hello. Here is pull request for this issue:
> >
> > https://github.com/apache/ignite/pull/2022
> >
> > 2017-05-26 13:16 GMT+03:00 Yakov Zhdanov <yz...@apache.org>:
> >
> > > Hi Nick! Good catch. Please go ahead and submit a patch.
> > >
> > > --Yakov
> > >
> > > 2017-05-26 13:09 GMT+03:00 Николай Ижиков <ni...@gmail.com>:
> > >
> > > > Hello, guys.
> > > >
> > > > public interface DiscoverySpi extends IgniteSpi {
> > > > ....
> > > > TcpDiscoverySpi setDataExchange(DiscoverySpiDataExchange var1);
> > > >
> > > > TcpDiscoverySpi setMetricsProvider(DiscoveryMetricsProvider
> var1);
> > > > ...
> > > > }
> > > >
> > > > Two methods of DiscoverySpi returns concrete implementation.
> > > > I think we should return interface, not implementation from this
> > methods
> > > > Or why we need an interface?
> > > >
> > > > I can provide simple patch to fix this issue.
> > > >
> > > > --
> > > > Nikolay Izhikov
> > > > NIzhikov.dev@gmail.com
> > > >
> > >
> >
> >
> >
> > --
> > Nikolay Izhikov
> > NIzhikov.dev@gmail.com
> >
>
--
Nikolay Izhikov
NIzhikov.dev@gmail.com
Re: DiscoverySpi#setDataExchange returns concrete implementation
Posted by Yakov Zhdanov <yz...@apache.org>.
Merged. Thanks for contribution, Nick. Please also see my edits.
--Yakov
2017-05-28 19:29 GMT+03:00 Николай Ижиков <ni...@gmail.com>:
> Hello. Here is pull request for this issue:
>
> https://github.com/apache/ignite/pull/2022
>
> 2017-05-26 13:16 GMT+03:00 Yakov Zhdanov <yz...@apache.org>:
>
> > Hi Nick! Good catch. Please go ahead and submit a patch.
> >
> > --Yakov
> >
> > 2017-05-26 13:09 GMT+03:00 Николай Ижиков <ni...@gmail.com>:
> >
> > > Hello, guys.
> > >
> > > public interface DiscoverySpi extends IgniteSpi {
> > > ....
> > > TcpDiscoverySpi setDataExchange(DiscoverySpiDataExchange var1);
> > >
> > > TcpDiscoverySpi setMetricsProvider(DiscoveryMetricsProvider var1);
> > > ...
> > > }
> > >
> > > Two methods of DiscoverySpi returns concrete implementation.
> > > I think we should return interface, not implementation from this
> methods
> > > Or why we need an interface?
> > >
> > > I can provide simple patch to fix this issue.
> > >
> > > --
> > > Nikolay Izhikov
> > > NIzhikov.dev@gmail.com
> > >
> >
>
>
>
> --
> Nikolay Izhikov
> NIzhikov.dev@gmail.com
>
Re: DiscoverySpi#setDataExchange returns concrete implementation
Posted by Николай Ижиков <ni...@gmail.com>.
Hello. Here is pull request for this issue:
https://github.com/apache/ignite/pull/2022
2017-05-26 13:16 GMT+03:00 Yakov Zhdanov <yz...@apache.org>:
> Hi Nick! Good catch. Please go ahead and submit a patch.
>
> --Yakov
>
> 2017-05-26 13:09 GMT+03:00 Николай Ижиков <ni...@gmail.com>:
>
> > Hello, guys.
> >
> > public interface DiscoverySpi extends IgniteSpi {
> > ....
> > TcpDiscoverySpi setDataExchange(DiscoverySpiDataExchange var1);
> >
> > TcpDiscoverySpi setMetricsProvider(DiscoveryMetricsProvider var1);
> > ...
> > }
> >
> > Two methods of DiscoverySpi returns concrete implementation.
> > I think we should return interface, not implementation from this methods
> > Or why we need an interface?
> >
> > I can provide simple patch to fix this issue.
> >
> > --
> > Nikolay Izhikov
> > NIzhikov.dev@gmail.com
> >
>
--
Nikolay Izhikov
NIzhikov.dev@gmail.com
Re: DiscoverySpi#setDataExchange returns concrete implementation
Posted by Yakov Zhdanov <yz...@apache.org>.
Hi Nick! Good catch. Please go ahead and submit a patch.
--Yakov
2017-05-26 13:09 GMT+03:00 Николай Ижиков <ni...@gmail.com>:
> Hello, guys.
>
> public interface DiscoverySpi extends IgniteSpi {
> ....
> TcpDiscoverySpi setDataExchange(DiscoverySpiDataExchange var1);
>
> TcpDiscoverySpi setMetricsProvider(DiscoveryMetricsProvider var1);
> ...
> }
>
> Two methods of DiscoverySpi returns concrete implementation.
> I think we should return interface, not implementation from this methods
> Or why we need an interface?
>
> I can provide simple patch to fix this issue.
>
> --
> Nikolay Izhikov
> NIzhikov.dev@gmail.com
>