You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/14 09:35:34 UTC

[GitHub] [beam] pavel-avilov opened a new pull request #17080: [BEAM-13880] [Playground] Increase test coverage for the setup_tools package

pavel-avilov opened a new pull request #17080:
URL: https://github.com/apache/beam/pull/17080


   [[BEAM-13880]](https://issues.apache.org/jira/browse/BEAM-13880)
   Add unit tests to increase test coverage for the setup_tools package.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #17080: [BEAM-13880] [Playground] Increase test coverage for the setup_tools package

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #17080:
URL: https://github.com/apache/beam/pull/17080#issuecomment-1082231014


   lgtm merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KhaninArtur commented on a change in pull request #17080: [BEAM-13880] [Playground] Increase test coverage for the setup_tools package

Posted by GitBox <gi...@apache.org>.
KhaninArtur commented on a change in pull request #17080:
URL: https://github.com/apache/beam/pull/17080#discussion_r829122590



##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -76,18 +112,18 @@ func TestValidator(t *testing.T) {
 			// As a result, want to receive an expected validator builder.
 			name: "Test correct validator builder",
 			args: args{
-				paths:  paths,
-				sdkEnv: sdkEnv,
+				paths:  pythonPaths,
+				sdkEnv: pythonSdkEnv,

Review comment:
       Should we do the same for Java, Go and SCIO SDKs?

##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -143,16 +179,16 @@ func TestPreparer(t *testing.T) {
 		{
 			// Test case with calling Setup with incorrect SDK.
 			// As a result, want to receive an error.
-			name:    "incorrect sdk",
-			args:    args{*paths, pipelineOptions, wrongSdkEnv, &validationResults},
+			name:    "Incorrect sdk",
+			args:    args{*pythonPaths, pipelineOptions, wrongSdkEnv, &validationResults},
 			want:    nil,
 			wantErr: true,
 		},
 		{
 			// Test case with calling Setup with correct SDK.
 			// As a result, want to receive an expected preparer builder.
-			name:    "correct sdk",
-			args:    args{*paths, pipelineOptions, sdkEnv, &validationResults},
+			name:    "Correct sdk",
+			args:    args{*pythonPaths, pipelineOptions, pythonSdkEnv, &validationResults},

Review comment:
       ditto

##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -195,10 +231,10 @@ func TestCompiler(t *testing.T) {
 		{
 			// Test case with calling Setup with correct data.
 			// As a result, want to receive an expected compiler builder.
-			name: "Test correct compiler builder",
+			name: "Test correct compiler builder with java sdk",

Review comment:
       Should we do the same test for Go and SCIO?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pavel-avilov commented on pull request #17080: [BEAM-13880] [Playground] Increase test coverage for the setup_tools package

Posted by GitBox <gi...@apache.org>.
pavel-avilov commented on pull request #17080:
URL: https://github.com/apache/beam/pull/17080#issuecomment-1066565934


   @ilya-kozyrev @KhaninArtur 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pavel-avilov commented on a change in pull request #17080: [BEAM-13880] [Playground] Increase test coverage for the setup_tools package

Posted by GitBox <gi...@apache.org>.
pavel-avilov commented on a change in pull request #17080:
URL: https://github.com/apache/beam/pull/17080#discussion_r832049550



##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -271,27 +403,49 @@ func TestTestRunner(t *testing.T) {
 		want *executors.ExecutorBuilder
 	}{
 		{
-			// Test case with calling Setup with correct data.
-			// As a result, want to receive an expected test builder.
-			name: "Test correct test builder",
+			name: "Test correct run builder with Java sdk",

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pavel-avilov commented on a change in pull request #17080: [BEAM-13880] [Playground] Increase test coverage for the setup_tools package

Posted by GitBox <gi...@apache.org>.
pavel-avilov commented on a change in pull request #17080:
URL: https://github.com/apache/beam/pull/17080#discussion_r832043255



##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -143,16 +179,16 @@ func TestPreparer(t *testing.T) {
 		{
 			// Test case with calling Setup with incorrect SDK.
 			// As a result, want to receive an error.
-			name:    "incorrect sdk",
-			args:    args{*paths, pipelineOptions, wrongSdkEnv, &validationResults},
+			name:    "Incorrect sdk",
+			args:    args{*pythonPaths, pipelineOptions, wrongSdkEnv, &validationResults},
 			want:    nil,
 			wantErr: true,
 		},
 		{
 			// Test case with calling Setup with correct SDK.
 			// As a result, want to receive an expected preparer builder.
-			name:    "correct sdk",
-			args:    args{*paths, pipelineOptions, sdkEnv, &validationResults},
+			name:    "Correct sdk",
+			args:    args{*pythonPaths, pipelineOptions, pythonSdkEnv, &validationResults},

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pavel-avilov commented on a change in pull request #17080: [BEAM-13880] [Playground] Increase test coverage for the setup_tools package

Posted by GitBox <gi...@apache.org>.
pavel-avilov commented on a change in pull request #17080:
URL: https://github.com/apache/beam/pull/17080#discussion_r832037110



##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -76,18 +112,18 @@ func TestValidator(t *testing.T) {
 			// As a result, want to receive an expected validator builder.
 			name: "Test correct validator builder",
 			args: args{
-				paths:  paths,
-				sdkEnv: sdkEnv,
+				paths:  pythonPaths,
+				sdkEnv: pythonSdkEnv,

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KhaninArtur commented on a change in pull request #17080: [BEAM-13880] [Playground] Increase test coverage for the setup_tools package

Posted by GitBox <gi...@apache.org>.
KhaninArtur commented on a change in pull request #17080:
URL: https://github.com/apache/beam/pull/17080#discussion_r829051978



##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -271,27 +403,49 @@ func TestTestRunner(t *testing.T) {
 		want *executors.ExecutorBuilder
 	}{
 		{
-			// Test case with calling Setup with correct data.
-			// As a result, want to receive an expected test builder.
-			name: "Test correct test builder",
+			name: "Test correct run builder with Java sdk",

Review comment:
       Shouldn't we also have the same test cases for Python SDK?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] KhaninArtur commented on a change in pull request #17080: [BEAM-13880] [Playground] Increase test coverage for the setup_tools package

Posted by GitBox <gi...@apache.org>.
KhaninArtur commented on a change in pull request #17080:
URL: https://github.com/apache/beam/pull/17080#discussion_r829122590



##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -76,18 +112,18 @@ func TestValidator(t *testing.T) {
 			// As a result, want to receive an expected validator builder.
 			name: "Test correct validator builder",
 			args: args{
-				paths:  paths,
-				sdkEnv: sdkEnv,
+				paths:  pythonPaths,
+				sdkEnv: pythonSdkEnv,

Review comment:
       Should we do the same for Java, Go and SCIO SDKs?

##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -143,16 +179,16 @@ func TestPreparer(t *testing.T) {
 		{
 			// Test case with calling Setup with incorrect SDK.
 			// As a result, want to receive an error.
-			name:    "incorrect sdk",
-			args:    args{*paths, pipelineOptions, wrongSdkEnv, &validationResults},
+			name:    "Incorrect sdk",
+			args:    args{*pythonPaths, pipelineOptions, wrongSdkEnv, &validationResults},
 			want:    nil,
 			wantErr: true,
 		},
 		{
 			// Test case with calling Setup with correct SDK.
 			// As a result, want to receive an expected preparer builder.
-			name:    "correct sdk",
-			args:    args{*paths, pipelineOptions, sdkEnv, &validationResults},
+			name:    "Correct sdk",
+			args:    args{*pythonPaths, pipelineOptions, pythonSdkEnv, &validationResults},

Review comment:
       ditto

##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -195,10 +231,10 @@ func TestCompiler(t *testing.T) {
 		{
 			// Test case with calling Setup with correct data.
 			// As a result, want to receive an expected compiler builder.
-			name: "Test correct compiler builder",
+			name: "Test correct compiler builder with java sdk",

Review comment:
       Should we do the same test for Go and SCIO?

##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -271,27 +403,49 @@ func TestTestRunner(t *testing.T) {
 		want *executors.ExecutorBuilder
 	}{
 		{
-			// Test case with calling Setup with correct data.
-			// As a result, want to receive an expected test builder.
-			name: "Test correct test builder",
+			name: "Test correct run builder with Java sdk",

Review comment:
       Shouldn't we also have the same test cases for Python SDK?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pavel-avilov commented on a change in pull request #17080: [BEAM-13880] [Playground] Increase test coverage for the setup_tools package

Posted by GitBox <gi...@apache.org>.
pavel-avilov commented on a change in pull request #17080:
URL: https://github.com/apache/beam/pull/17080#discussion_r832046892



##########
File path: playground/backend/internal/setup_tools/builder/setup_builder_test.go
##########
@@ -195,10 +231,10 @@ func TestCompiler(t *testing.T) {
 		{
 			// Test case with calling Setup with correct data.
 			// As a result, want to receive an expected compiler builder.
-			name: "Test correct compiler builder",
+			name: "Test correct compiler builder with java sdk",

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #17080: [BEAM-13880] [Playground] Increase test coverage for the setup_tools package

Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #17080:
URL: https://github.com/apache/beam/pull/17080


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org