You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/10/03 16:43:45 UTC
Re: Review Request 62643: Propagated the container termination to the agent API.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62643/#review186962
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/agent/agent.proto
Lines 338 (patched)
<https://reviews.apache.org/r/62643/#comment263902>

    Please add some comment about this field. So basically, if specified, this `state` should be used for the task that is associated with this container.



include/mesos/agent/agent.proto
Lines 346 (patched)
<https://reviews.apache.org/r/62643/#comment263900>

    Can you rename this to `limited_resources` to be in sync with that in `TaskStatus`?



include/mesos/slave/containerizer.proto
Lines 256 (patched)
<https://reviews.apache.org/r/62643/#comment263903>

    Ditto. `limited_resources`



include/mesos/v1/agent/agent.proto
Lines 338-346 (patched)
<https://reviews.apache.org/r/62643/#comment263905>

    Ditto.


- Jie Yu


On Sept. 28, 2017, 12:19 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62643/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2017, 12:19 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-7963
>     https://issues.apache.org/jira/browse/MESOS-7963
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the agent API so that we can propagate information
> from the container termination up to the `WaitNestedContainer`
> response. We now propagate resources all the way from the
> container limitation to the `WaitNestedContainer` response so
> that an executor can know specifically which resource limit
> violation caused the container termination.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 7c8c8a7d8298e91e4e002327b3b27d4c74b5cbae 
>   include/mesos/slave/containerizer.proto 84f9ca765fe6e29ddd2f7956ba0976e10b21d685 
>   include/mesos/v1/agent/agent.proto 3e199124b23fa027232790d99370fe2f33660096 
>   src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345 
>   src/slave/http.cpp 3ea7829df8c1c35d2fa3a44f19a60b7e261042ce 
> 
> 
> Diff: https://reviews.apache.org/r/62643/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>