You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sirona.apache.org by ol...@apache.org on 2015/11/26 11:21:33 UTC

svn commit: r1716594 - in /incubator/sirona/trunk/agent/javaagent/src: main/java/org/apache/sirona/javaagent/listener/PathTrackingListener.java test/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationRecursiveTest.java

Author: olamy
Date: Thu Nov 26 10:21:33 2015
New Revision: 1716594

URL: http://svn.apache.org/viewvc?rev=1716594&view=rev
Log:
remove this noisy logging

Signed-off-by: olivier lamy <ol...@apache.org>

Modified:
    incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingListener.java
    incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationRecursiveTest.java

Modified: incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingListener.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingListener.java?rev=1716594&r1=1716593&r2=1716594&view=diff
==============================================================================
--- incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingListener.java (original)
+++ incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/listener/PathTrackingListener.java Thu Nov 26 10:21:33 2015
@@ -19,10 +19,9 @@ package org.apache.sirona.javaagent.list
 import org.apache.sirona.configuration.Configuration;
 import org.apache.sirona.configuration.ioc.AutoSet;
 import org.apache.sirona.javaagent.AgentContext;
-import org.apache.sirona.javaagent.logging.SironaAgentLogging;
+import org.apache.sirona.javaagent.tracking.PathTracker;
 import org.apache.sirona.pathtracking.PathTrackingInformation;
 import org.apache.sirona.spi.Order;
-import org.apache.sirona.javaagent.tracking.PathTracker;
 
 @Order( 1 )
 @AutoSet
@@ -37,6 +36,7 @@ import org.apache.sirona.javaagent.track
     private static final boolean TRACKING_ACTIVATED =
         Configuration.is( Configuration.CONFIG_PROPERTY_PREFIX + "javaagent.path.tracking.activate", false );
 
+
     @Override
     public boolean accept( String key, byte[] rawClassBuffer )
     {
@@ -46,16 +46,13 @@ import org.apache.sirona.javaagent.track
             return false;
         }
 
-        SironaAgentLogging.debug( "PathTrackingListener#accept, TRACKING_ACTIVATED: {0}, key: {1}", TRACKING_ACTIVATED,
-                                  key );
-
         return TRACKING_ACTIVATED;
     }
 
     /**
      * executed before method called to configure the start {@link org.apache.sirona.pathtracking.PathTrackingInformation}
      * and set various thread local variable as invocation level
-     * will call {@link org.apache.sirona.javaagent.tracking.PathTracker#start(org.apache.sirona.pathtracking.PathTrackingInformation)}
+     * will call {@link org.apache.sirona.javaagent.tracking.PathTracker#start(PathTrackingInformation, Object)}
      *
      * @param context
      */
@@ -64,15 +61,12 @@ import org.apache.sirona.javaagent.track
     {
 
         String key = context.getKey();
-        SironaAgentLogging.debug( "PathTrackingListener#before: {0}", key );
 
         String className = extractClassName( key );
         String methodName = extractMethodName( key );
 
         final PathTrackingInformation pathTrackingInformation = new PathTrackingInformation( className, methodName );
 
-        SironaAgentLogging.debug( "call PathTracker#start with {0}", pathTrackingInformation );
-
         context.put( PATH_TRACKER_KEY, PathTracker.start( pathTrackingInformation, context.getReference() ) );
     }
 
@@ -135,9 +129,6 @@ import org.apache.sirona.javaagent.track
     @Override
     public void after( AgentContext context, Object result, Throwable error )
     {
-
-        SironaAgentLogging.debug( "PathTrackingListener#after: {0}", context.getKey() );
-
         context.get( PATH_TRACKER_KEY, PathTracker.class ).stop( context.getReference() );
     }
 }

Modified: incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationRecursiveTest.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationRecursiveTest.java?rev=1716594&r1=1716593&r2=1716594&view=diff
==============================================================================
--- incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationRecursiveTest.java (original)
+++ incubator/sirona/trunk/agent/javaagent/src/test/java/org/apache/sirona/javaagent/listener/PathTrackingInvocationRecursiveTest.java Thu Nov 26 10:21:33 2015
@@ -68,7 +68,7 @@ public class PathTrackingInvocationRecur
 
         Assert.assertTrue( !all.isEmpty() );
 
-        Assert.assertEquals( 4, all.size() );
+        Assert.assertEquals( 2, all.size() );
 
     }