You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@phoenix.apache.org by ra...@apache.org on 2017/05/25 04:23:48 UTC

phoenix git commit: PHOENIX-3886 Illegal Data exception is throwing in upserts involving PChar columns in Phoenix-Calcite(Rajeshbabu)

Repository: phoenix
Updated Branches:
  refs/heads/calcite d2b995c83 -> 41a3b7f9c


PHOENIX-3886 Illegal Data exception is throwing in upserts involving PChar columns in Phoenix-Calcite(Rajeshbabu)


Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/41a3b7f9
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/41a3b7f9
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/41a3b7f9

Branch: refs/heads/calcite
Commit: 41a3b7f9ce5a98d1bbe0e757ef98c2390daf70d8
Parents: d2b995c
Author: Rajeshbabu Chintaguntla <ra...@apache.org>
Authored: Thu May 25 09:52:45 2017 +0530
Committer: Rajeshbabu Chintaguntla <ra...@apache.org>
Committed: Thu May 25 09:52:45 2017 +0530

----------------------------------------------------------------------
 .../org/apache/phoenix/expression/BindParameterExpression.java     | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/phoenix/blob/41a3b7f9/phoenix-core/src/main/java/org/apache/phoenix/expression/BindParameterExpression.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/main/java/org/apache/phoenix/expression/BindParameterExpression.java b/phoenix-core/src/main/java/org/apache/phoenix/expression/BindParameterExpression.java
index b353757..ce23b30 100644
--- a/phoenix-core/src/main/java/org/apache/phoenix/expression/BindParameterExpression.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/expression/BindParameterExpression.java
@@ -3,6 +3,7 @@ package org.apache.phoenix.expression;
 import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
 import org.apache.phoenix.execute.RuntimeContext;
 import org.apache.phoenix.expression.visitor.ExpressionVisitor;
+import org.apache.phoenix.schema.SortOrder;
 import org.apache.phoenix.schema.tuple.Tuple;
 import org.apache.phoenix.schema.types.PDataType;
 
@@ -27,6 +28,7 @@ public class BindParameterExpression extends VariableExpression {
         }
         
         ptr.set(type.toBytes(value));
+        type.pad(ptr, maxLength, SortOrder.ASC);
         return true;
     }