You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Arpit Gupta (Created) (JIRA)" <ji...@apache.org> on 2011/10/11 07:46:30 UTC
[jira] [Created] (HDFS-2432) webhdfs setreplication api should
return a 400 when called on a directory
webhdfs setreplication api should return a 400 when called on a directory
-------------------------------------------------------------------------
Key: HDFS-2432
URL: https://issues.apache.org/jira/browse/HDFS-2432
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Arpit Gupta
Currently the set replication api on a directory leads to a 200.
Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
Request Method: PUT
Status Line: HTTP/1.1 200 OK
Response Content: {"boolean":false}
Since we can determine that this call did not succeed (boolean=false) we should rather just return a 400 (Bad Request)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138284#comment-13138284 ]
Hudson commented on HDFS-2432:
------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #53 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/53/])
svn merge -c 1190077 from trunk for HDFS-2432.
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190082
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0
>
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch, h2432_20111027.patch, h2432_20111027_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137863#comment-13137863 ]
Hudson commented on HDFS-2432:
------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #65 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/65/])
svn merge -c 1190077 from trunk for HDFS-2432.
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190082
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0
>
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch, h2432_20111027.patch, h2432_20111027_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Arpit Gupta (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arpit Gupta updated HDFS-2432:
------------------------------
Description:
Currently the set replication api on a directory leads to a 200.
Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
Request Method: PUT
Status Line: HTTP/1.1 200 OK
Response Content: {"boolean":false}
Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
was:
Currently the set replication api on a directory leads to a 200.
Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
Request Method: PUT
Status Line: HTTP/1.1 200 OK
Response Content: {"boolean":false}
Since we can determine that this call did not succeed (boolean=false) we should rather just return a 400 (Bad Request)
Summary: webhdfs setreplication api should return a 403 when called on a directory (was: webhdfs setreplication api should return a 400 when called on a directory)
Thanks for the input praveen.
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-2432:
-----------------------------------------
Assignee: Tsz Wo (Nicholas), SZE
Target Version/s: 0.20.205.1, 0.23.0, 0.24.0 (was: 0.24.0, 0.23.0, 0.20.205.1)
Status: Patch Available (was: Open)
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137729#comment-13137729 ]
Hudson commented on HDFS-2432:
------------------------------
Integrated in Hadoop-Common-0.23-Commit #88 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/88/])
svn merge -c 1190077 from trunk for HDFS-2432.
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190082
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0
>
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch, h2432_20111027.patch, h2432_20111027_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2432) webhdfs setreplication api should
return a 400 when called on a directory
Posted by "Praveen Kumar K J V S (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124771#comment-13124771 ]
Praveen Kumar K J V S commented on HDFS-2432:
---------------------------------------------
Its better to return HTTP Status code 403 (Forbidden), because setting a replication factor on a directory is not a bad request per se, just that its not allowed in HDFS. (probably in future this might be a feature in future where replication factors can be defined for directories, there are definite use-cases though)
As per the specification:
400 Bad Request -
The request could not be understood by the server due to malformed syntax. The client SHOULD NOT repeat the request without modifications.
403 Forbidden -
The server understood the request, but is refusing to fulfill it. ...
> webhdfs setreplication api should return a 400 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 400 (Bad Request)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-2432:
----------------------------------
Target Version/s: 1.0.0, 0.23.0, 0.24.0 (was: 0.23.0, 0.24.0, 1.0.0)
Fix Version/s: (was: 1.1.0)
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: webhdfs
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.23.0, 0.24.0, 1.0.0
>
> Attachments: h2432_20111026_0.20s.patch, h2432_20111026.patch, h2432_20111027_0.20s.patch, h2432_20111027.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-2432:
-----------------------------------------
Attachment: h2432_20111027.patch
h2432_20111027_0.20s.patch
h2432_20111027_0.20s.patch
h2432_20111027.patch
Fixed a silly bug.
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch, h2432_20111027.patch, h2432_20111027_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-2432:
-----------------------------------------
Resolution: Fixed
Fix Version/s: 0.24.0
0.23.0
0.20.206.0
0.20.205.1
Target Version/s: 0.20.205.1, 0.23.0, 0.24.0 (was: 0.24.0, 0.23.0, 0.20.205.1)
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Thanks Jitendra for the review.
The failed tests are not related.
I have committed this.
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0
>
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch, h2432_20111027.patch, h2432_20111027_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2432) webhdfs setreplication api should
return a 400 when called on a directory
Posted by "Arpit Gupta (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arpit Gupta updated HDFS-2432:
------------------------------
Affects Version/s: 0.20.205.0
> webhdfs setreplication api should return a 400 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 400 (Bad Request)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137732#comment-13137732 ]
Hudson commented on HDFS-2432:
------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #88 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/88/])
svn merge -c 1190077 from trunk for HDFS-2432.
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190082
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0
>
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch, h2432_20111027.patch, h2432_20111027_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136805#comment-13136805 ]
Hadoop QA commented on HDFS-2432:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501030/h2432_20111026.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 8 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hdfs.TestFileAppend2
org.apache.hadoop.hdfs.TestBalancerBandwidth
org.apache.hadoop.hdfs.TestDistributedFileSystem
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1471//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1471//console
This message is automatically generated.
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136904#comment-13136904 ]
Hadoop QA commented on HDFS-2432:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501048/h2432_20111027.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 8 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hdfs.TestFileAppend2
org.apache.hadoop.hdfs.TestBalancerBandwidth
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1473//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1473//console
This message is automatically generated.
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch, h2432_20111027.patch, h2432_20111027_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137743#comment-13137743 ]
Hudson commented on HDFS-2432:
------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #84 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/84/])
svn merge -c 1190077 from trunk for HDFS-2432.
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190082
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0
>
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch, h2432_20111027.patch, h2432_20111027_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-2432:
-----------------------------------------
Issue Type: Sub-task (was: Bug)
Parent: HDFS-2316
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137726#comment-13137726 ]
Hudson commented on HDFS-2432:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #1180 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1180/])
HDFS-2432. Webhdfs: response FORBIDDEN when setReplication on non-files; clear umask before creating a flie; throw IllegalArgumentException if setOwner with both owner and group empty; throw FileNotFoundException if getFileStatus on non-existing files; fix bugs in getBlockLocations; and changed getFileChecksum json response root to "FileChecksum".
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190077
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0
>
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch, h2432_20111027.patch, h2432_20111027_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138365#comment-13138365 ]
Hudson commented on HDFS-2432:
------------------------------
Integrated in Hadoop-Hdfs-trunk #846 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/846/])
HDFS-2432. Webhdfs: response FORBIDDEN when setReplication on non-files; clear umask before creating a flie; throw IllegalArgumentException if setOwner with both owner and group empty; throw FileNotFoundException if getFileStatus on non-existing files; fix bugs in getBlockLocations; and changed getFileChecksum json response root to "FileChecksum".
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190077
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0
>
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch, h2432_20111027.patch, h2432_20111027_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-2432:
-----------------------------------------
Target Version/s: 0.20.205.1, 0.23.0, 0.24.0
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-2432:
-----------------------------------------
Attachment: h2432_20111026.patch
h2432_20111026_0.20s.patch
h2432_20111026_0.20s.patch
h2432_20111026.patch
Fixes various bugs in webhdfs:
- response FORBIDDEN when setReplications on non-files.
- clear umask before creating a flie. (HDFS-2468)
- throw IllegalArgumentException if setOwner with both owner and group empty. (HDFS-2438)
- throw FileNotFoundException if getFileStatus on non-existing file. (HDFS-2426)
- fixed bugs in getBlockLocations. (HDFS-2508)
- changed file checksum json response root from "MD5MD5CRC32FileChecksum" to "FileChecksum". (Thanks Arpit for the suggestion.)
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Jitendra Nath Pandey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137581#comment-13137581 ]
Jitendra Nath Pandey commented on HDFS-2432:
--------------------------------------------
+1 lgtm.
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch, h2432_20111027.patch, h2432_20111027_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137831#comment-13137831 ]
Hudson commented on HDFS-2432:
------------------------------
Integrated in Hadoop-Mapreduce-trunk #874 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/874/])
HDFS-2432. Webhdfs: response FORBIDDEN when setReplication on non-files; clear umask before creating a flie; throw IllegalArgumentException if setOwner with both owner and group empty; throw FileNotFoundException if getFileStatus on non-existing files; fix bugs in getBlockLocations; and changed getFileChecksum json response root to "FileChecksum".
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190077
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0
>
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch, h2432_20111027.patch, h2432_20111027_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137741#comment-13137741 ]
Hudson commented on HDFS-2432:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1196 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1196/])
HDFS-2432. Webhdfs: response FORBIDDEN when setReplication on non-files; clear umask before creating a flie; throw IllegalArgumentException if setOwner with both owner and group empty; throw FileNotFoundException if getFileStatus on non-existing files; fix bugs in getBlockLocations; and changed getFileChecksum json response root to "FileChecksum".
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190077
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0
>
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch, h2432_20111027.patch, h2432_20111027_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2432) webhdfs setreplication api should
return a 403 when called on a directory
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137723#comment-13137723 ]
Hudson commented on HDFS-2432:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1257 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1257/])
HDFS-2432. Webhdfs: response FORBIDDEN when setReplication on non-files; clear umask before creating a flie; throw IllegalArgumentException if setOwner with both owner and group empty; throw FileNotFoundException if getFileStatus on non-existing files; fix bugs in getBlockLocations; and changed getFileChecksum json response root to "FileChecksum".
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190077
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
> Key: HDFS-2432
> URL: https://issues.apache.org/jira/browse/HDFS-2432
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 0.20.205.0
> Reporter: Arpit Gupta
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0
>
> Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch, h2432_20111027.patch, h2432_20111027_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira