You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/02/18 22:08:27 UTC
[GitHub] [guacamole-server] jmuehlner opened a new pull request #371: GUACAMOLE-1540: Docker build using Ubuntu 21.10 as a base
jmuehlner opened a new pull request #371:
URL: https://github.com/apache/guacamole-server/pull/371
See [GUACAMOLE-1540](https://issues.apache.org/jira/browse/GUACAMOLE-1540) - this change is confirmed to fix the SSH key extraction issues I was having with the old buster build.
The only real changes of note here are the replacement of `libjpeg62-turbo-dev` with `libjpeg-dev`, and the modification of the `list-dependencies.sh` script to change the way it identifies dependencies.
When testing out this change, I found that the file paths that were linked against are _NOT_ the same paths that are package-managed.
For example: `libjpeg-turbo8` packages `/usr/lib/x86_64-linux-gnu/libjpeg.so.8`, but the libraries are actually built against `/lib/x86_64-linux-gnu/libjpeg.so.8.2.2`. These two files are hard-linked, but `dpkg` does not understand this, so it failed to find the `libjpeg-turbo8` dependency. The same is true for many other files. Searching by file name instead of absolute path fixes this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #371: GUACAMOLE-1540: Docker build using Ubuntu 21.10 as a base
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #371:
URL: https://github.com/apache/guacamole-server/pull/371#discussion_r810396918
##########
File path: Dockerfile
##########
@@ -58,7 +58,7 @@ ARG BUILD_DEPENDENCIES=" \
gcc \
libcairo2-dev \
libgcrypt-dev \
- libjpeg62-turbo-dev \
+ libjpeg-dev \
Review comment:
I believe Ubuntu does have a libjpeg-turbo package, just a newer version with a different name: https://guacamole.apache.org/doc/gug/installing-guacamole.html#required-dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] jmuehlner commented on a change in pull request #371: GUACAMOLE-1540: Docker build using Ubuntu 21.10 as a base
Posted by GitBox <gi...@apache.org>.
jmuehlner commented on a change in pull request #371:
URL: https://github.com/apache/guacamole-server/pull/371#discussion_r810402430
##########
File path: Dockerfile
##########
@@ -58,7 +58,7 @@ ARG BUILD_DEPENDENCIES=" \
gcc \
libcairo2-dev \
libgcrypt-dev \
- libjpeg62-turbo-dev \
+ libjpeg-dev \
Review comment:
Ah, good call. I'll give that one a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] jmuehlner commented on a change in pull request #371: GUACAMOLE-1540: Docker build using Ubuntu 21.10 as a base
Posted by GitBox <gi...@apache.org>.
jmuehlner commented on a change in pull request #371:
URL: https://github.com/apache/guacamole-server/pull/371#discussion_r810404661
##########
File path: Dockerfile
##########
@@ -58,7 +58,7 @@ ARG BUILD_DEPENDENCIES=" \
gcc \
libcairo2-dev \
libgcrypt-dev \
- libjpeg62-turbo-dev \
+ libjpeg-dev \
Review comment:
Ok, confirmed `libjpeg-turbo8-dev` works. Switched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] mike-jumper merged pull request #371: GUACAMOLE-1540: Docker build using Ubuntu 21.10 as a base
Posted by GitBox <gi...@apache.org>.
mike-jumper merged pull request #371:
URL: https://github.com/apache/guacamole-server/pull/371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org