[GitHub] [iceberg] stevenzwu commented on a diff in pull request #4886: Address Anton's comments from the PR 4744 (incremental append scan impl)

[GitBox <gi...@apache.org>]

stevenzwu commented on code in PR #4886:
URL: https://github.com/apache/iceberg/pull/4886#discussion_r884361598


##########
core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java:
##########
@@ -132,7 +132,7 @@ public static Snapshot oldestAncestor(Table table) {
    * @param lookup lookup function from snapshot ID to snapshot
    * @return null if there is no current snapshot in the table, else the oldest Snapshot.
    */
-  public static Snapshot oldestAncestor(long snapshotId, Function<Long, Snapshot> lookup) {
+  public static Snapshot oldestAncestorOf(long snapshotId, Function<Long, Snapshot> lookup) {

Review Comment:
   this was added by the other PR #4744 (incremental append scan impl) that just merged. It is not released and should be safe to rename



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org