You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/02/16 07:34:29 UTC
[kudu-CR] [test] fix flake in TestConcurrentRepeatedCommitCalls
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17069
Change subject: [test] fix flake in TestConcurrentRepeatedCommitCalls
......................................................................
[test] fix flake in TestConcurrentRepeatedCommitCalls
Before this patch, the TestConcurrentRepeatedCommitCalls scenario
of the TxnCommitITest sometimes failed with an error like below:
Bad status: Illegal state: Failed to write to server: 206a8320b5ea4e4c80360fd3de898ab5 (127.0.93.65:36189): transaction ID 0 is not open: state: COMMITTED user: "slave"
Before this patch, I saw such an error in about 1/8 of all DEBUG build
runs if specifying --stress_cpu_threads=16. After this patch, I saw
none after running the scenario with the same flags hundreds of times.
Change-Id: I39118b2b33503a18b77e4e4106979f141b5e5486
---
M src/kudu/integration-tests/txn_commit-itest.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/17069/1
--
To view, visit http://gerrit.cloudera.org:8080/17069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39118b2b33503a18b77e4e4106979f141b5e5486
Gerrit-Change-Number: 17069
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [test] fix flake in TestConcurrentRepeatedCommitCalls
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17069 )
Change subject: [test] fix flake in TestConcurrentRepeatedCommitCalls
......................................................................
Patch Set 1:
> Thanks! I'll update the logic so BeginCommit calls after we're
> COMMITTED to be OK.
Cool! I wasn't sure it would be the right thing to do when quickly looking into the code. But after some consideration I agree it make sense to return OK on BeginCommit() even if state of the transaction is COMMITED, so the behavior is no longer time-sensitive as of now (we now accept such a call if the state COMMIT_IN_PROGRESS, but reject if the state is COMMITTED).
--
To view, visit http://gerrit.cloudera.org:8080/17069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39118b2b33503a18b77e4e4106979f141b5e5486
Gerrit-Change-Number: 17069
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 16 Feb 2021 19:18:34 +0000
Gerrit-HasComments: No
[kudu-CR] [test] fix flake in TestConcurrentRepeatedCommitCalls
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [test] fix flake in TestConcurrentRepeatedCommitCalls
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I39118b2b33503a18b77e4e4106979f141b5e5486
Gerrit-Change-Number: 17069
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] fix flake in TestConcurrentRepeatedCommitCalls
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17069 )
Change subject: [test] fix flake in TestConcurrentRepeatedCommitCalls
......................................................................
Patch Set 1: Code-Review+2
Thanks! I'll update the logic so BeginCommit calls after we're COMMITTED to be OK.
--
To view, visit http://gerrit.cloudera.org:8080/17069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39118b2b33503a18b77e4e4106979f141b5e5486
Gerrit-Change-Number: 17069
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 16 Feb 2021 18:41:16 +0000
Gerrit-HasComments: No
[kudu-CR] [test] fix flake in TestConcurrentRepeatedCommitCalls
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17069 )
Change subject: [test] fix flake in TestConcurrentRepeatedCommitCalls
......................................................................
Patch Set 1: Verified+1
unrelated test failures in
* RebalanceParamTest.Rebalance/3
* BlockManagerType/TsRecoveryITest.TestChangeMaxCellSize/0
--
To view, visit http://gerrit.cloudera.org:8080/17069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39118b2b33503a18b77e4e4106979f141b5e5486
Gerrit-Change-Number: 17069
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 16 Feb 2021 15:23:17 +0000
Gerrit-HasComments: No
[kudu-CR] [test] fix flake in TestConcurrentRepeatedCommitCalls
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17069 )
Change subject: [test] fix flake in TestConcurrentRepeatedCommitCalls
......................................................................
[test] fix flake in TestConcurrentRepeatedCommitCalls
Before this patch, the TestConcurrentRepeatedCommitCalls scenario
of the TxnCommitITest sometimes failed with an error like below:
Bad status: Illegal state: Failed to write to server: 206a8320b5ea4e4c80360fd3de898ab5 (127.0.93.65:36189): transaction ID 0 is not open: state: COMMITTED user: "slave"
Before this patch, I saw such an error in about 1/8 of all DEBUG build
runs if specifying --stress_cpu_threads=16. After this patch, I saw
none after running the scenario with the same flags hundreds of times.
Change-Id: I39118b2b33503a18b77e4e4106979f141b5e5486
Reviewed-on: http://gerrit.cloudera.org:8080/17069
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/integration-tests/txn_commit-itest.cc
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alexey Serbin: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I39118b2b33503a18b77e4e4106979f141b5e5486
Gerrit-Change-Number: 17069
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)