[jira] Commented: (HBASE-3531) When under global memstore pressure, may try to flush unflushable regions in a tight loop

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994531#comment-12994531 ] 

Ted Yu commented on HBASE-3531:
-------------------------------

I think flushOneForGlobalPressure should check whether isAboveLowWaterMark() is still true.


> When under global memstore pressure, may try to flush unflushable regions in a tight loop
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-3531
>                 URL: https://issues.apache.org/jira/browse/HBASE-3531
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.1
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>             Fix For: 0.90.1
>
>         Attachments: 3531.txt
>
>
> Ted ran into this in cluster testing. If the largest region is unflushable (eg it's in the midst of closing during a split, and hence doing its own flush), the global memstore pressure code doesn't notice this. So, it keeps trying to flush it, and ignores the false return code from flushRegion.
> Instead, we should iterate down the list of regions and keep trying to flush them until we find one that works.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira