You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2016/10/20 16:03:15 UTC
[GitHub] cordova-windows pull request #205: CB-12044 Fix splashscreen image path for ...
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-windows/pull/205
CB-12044 Fix splashscreen image path for ms-appx on Windows
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows
### What does this PR do?
1. Fix splashscreen image path for ms-appx on Windows 10:
`<preference name="WindowsDefaultUriPrefix" value="ms-appx://" />`
2. Updated cordova-js to latest
### What testing has been done on this change?
Tested for CLI and platform scripts cases
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-windows CB-12044
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #205
----
commit bf9a49ae49e30750cd3e7a43a8aee84f87a885bb
Author: daserge <v-...@microsoft.com>
Date: 2016-10-20T15:55:45Z
CB-12044 Fix splashscreen image path for ms-appx on Windows
Updated cordova-js to latest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request #205: CB-12044 Fix splashscreen image path for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/205
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #205: CB-12044 Fix splashscreen image path for ms-appx...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-windows/pull/205
## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/205?src=pr) is 74.64% (diff: 100%)
> Merging [#205](https://codecov.io/gh/apache/cordova-windows/pull/205?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will not change coverage
```diff
@@ master #205 diff @@
==========================================
Files 15 15
Lines 2067 2067
Methods 390 390
Messages 0 0
Branches 403 403
==========================================
Hits 1543 1543
Misses 524 524
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [7d9b24c...bf9a49a](https://codecov.io/gh/apache/cordova-windows/compare/7d9b24cecd05cd4392824a465b8f447931d5817f...bf9a49ae49e30750cd3e7a43a8aee84f87a885bb?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org