You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2019/08/22 22:45:52 UTC
[impala] branch master updated: IMPALA-8516: Fix the sha512sum
check for the Maven download
This is an automated email from the ASF dual-hosted git repository.
tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new 3787e47 IMPALA-8516: Fix the sha512sum check for the Maven download
3787e47 is described below
commit 3787e47d74e5964d3f3ea2f4b05c3f5f8ec2ee84
Author: Laszlo Gaal <la...@cloudera.com>
AuthorDate: Wed Jul 17 13:40:06 2019 +0200
IMPALA-8516: Fix the sha512sum check for the Maven download
This is a follow-up fix for commit 327b938214:
When bin/bootstrap_system.sh downloads Maven, it performs a checksum
check on the downloaded archive before expanding it. The check is
performed using sha512sum, which has quite particular requirements
for its inputs:
When checking, the input should be a former output of this program.
The default mode is to print a line with checksum, a character
indicating input mode ('*' for binary, space for text),
and name for each FILE.
In our case the checksum lines ended up having two space characters
between the checksum and the file name. Unfortunately, when the
original commit copied the maven download-and-install stanza to
the new location, the second whitespace was dropped, which made this
line fail on CentOS 6, where the sha512sum implementation takes the
above quoted requirement literally.
This patch restores the extra whitespace, fixing Maven installation
for CentOS 6.
Change-Id: Ic8aa4d78b34d60a01fc8f6afc336d66ee5a005cb
Reviewed-on: http://gerrit.cloudera.org:8080/13876
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
bin/bootstrap_system.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bin/bootstrap_system.sh b/bin/bootstrap_system.sh
index d24aed4..d2a7860 100755
--- a/bin/bootstrap_system.sh
+++ b/bin/bootstrap_system.sh
@@ -247,7 +247,7 @@ redhat sudo ln -s /usr/local/apache-ant-1.9.13/bin/ant /usr/local/bin
if [ ! -d /usr/local/apache-maven-3.5.4 ]; then
sudo wget -nv \
https://www-us.apache.org/dist/maven/maven-3/3.5.4/binaries/apache-maven-3.5.4-bin.tar.gz
- sha512sum -c - <<< '2a803f578f341e164f6753e410413d16ab60fabe31dc491d1fe35c984a5cce696bc71f57757d4538fe7738be04065a216f3ebad4ef7e0ce1bb4c51bc36d6be86 apache-maven-3.5.4-bin.tar.gz'
+ sha512sum -c - <<< '2a803f578f341e164f6753e410413d16ab60fabe31dc491d1fe35c984a5cce696bc71f57757d4538fe7738be04065a216f3ebad4ef7e0ce1bb4c51bc36d6be86 apache-maven-3.5.4-bin.tar.gz'
sudo tar -C /usr/local -xzf apache-maven-3.5.4-bin.tar.gz
sudo ln -s /usr/local/apache-maven-3.5.4/bin/mvn /usr/local/bin
fi