You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/01 16:07:11 UTC

[GitHub] [beam] lostluck commented on a change in pull request #17147: [BEAM-14153] Reshuffled Row Coder PCollection used as Side Input cause encoder issues.

lostluck commented on a change in pull request #17147:
URL: https://github.com/apache/beam/pull/17147#discussion_r840729416



##########
File path: sdks/go/pkg/beam/core/runtime/graphx/translate.go
##########
@@ -66,8 +65,7 @@ const (
 	URNLegacyProgressReporting = "beam:protocol:progress_reporting:v0"
 	URNMultiCore               = "beam:protocol:multi_core_bundle_processing:v1"
 
-	URNRequiresSplittableDoFn     = "beam:requirement:pardo:splittable_dofn:v1"
-	URNRequiresBundleFinalization = "beam:requirement:pardo:finalization:v1"
+	URNRequiresSplittableDoFn = "beam:requirement:pardo:splittable_dofn:v1"

Review comment:
       Ah whoops!
   I spent all my effort making sure the proto didn't get clobbered, I forgot about the rest of the change. Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org