You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/11/05 07:33:48 UTC
[kudu-CR] KUDU-3334 hide protobuf symbols in libkudu client
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18000
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client
......................................................................
KUDU-3334 hide protobuf symbols in libkudu_client
As it turns out, there are conflicts during static initialization of
symbols related to protobuf extensions in an application linking in
libkudu_client and also dynamically linked against libprotobuf. That
seems to be attributed to the creation of two independent descriptor
pools in such cases [1]. At least, such issues became apparent when
both the application and libkudu_client started using libprotobuf
3.14.0.
One example of an application described above is impalad. It links in
libkudu_client and libprotobuf: the latter is necessary to communicate
with other Impala's backend components via KRPC.
This patch adds extra flags for the linker to completely hide all the
symbols inherited by libkudu_client from libprotobuf which is statically
linked into the Kudu C++ library in case of RELEASE builds.
As for the rest of libraries statically linked into libkudu_client,
it seems no problems encountered so far if those symbols are just made
local using the version script mechanism, so no other libraries are put
under --exclude-libs linker's flag except for libprotobuf.
[1] https://stackoverflow.com/questions/29960871/protobuf-message-object-creation-by-name
Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
---
M src/kudu/client/CMakeLists.txt
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/18000/1
--
To view, visit http://gerrit.cloudera.org:8080/18000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
Gerrit-Change-Number: 18000
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-3334 hide protobuf symbols in libkudu client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Joe McDonnell, Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18000
to look at the new patch set (#3).
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client
......................................................................
KUDU-3334 hide protobuf symbols in libkudu_client
As it turns out, there are conflicts during static initialization of
symbols related to protobuf extensions in an application using
libkudu_client and also linking in libprotobuf on its own. That
seems to be attributed to the creation of two independent descriptor
pools in such cases [1]. At least, such issues became apparent when
both the application and libkudu_client started using libprotobuf
3.14.0.
One example of an application described above is impalad. It links in
libkudu_client and libprotobuf: the former is used to talk to Kudu
servers and the latter is necessary to communicate with other Impala's
backend components via KRPC.
This patch adds the --exclude-libs flag for the GNU linker [2] to
completely hide all the symbols inherited by libkudu_client from
libprotobuf which is statically linked into the Kudu C++ library
in case of RELEASE builds.
As for the rest of libraries statically linked into libkudu_client,
it seems no problems encountered so far if those symbols are just made
local using the version script mechanism, so no other libraries are put
under --exclude-libs linker's flag except for libprotobuf.
[1] https://stackoverflow.com/a/29975019
[2] https://www.man7.org/linux/man-pages/man1/ld.1.html
Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
---
M src/kudu/client/CMakeLists.txt
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/18000/3
--
To view, visit http://gerrit.cloudera.org:8080/18000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
Gerrit-Change-Number: 18000
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[kudu-CR] KUDU-3334 hide protobuf symbols in libkudu client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Joe McDonnell, Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18000
to look at the new patch set (#2).
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client
......................................................................
KUDU-3334 hide protobuf symbols in libkudu_client
As it turns out, there are conflicts during static initialization of
symbols related to protobuf extensions in an application using
libkudu_client and also dynamically linked against libprotobuf. That
seems to be attributed to the creation of two independent descriptor
pools in such cases [1]. At least, such issues became apparent when
both the application and libkudu_client started using libprotobuf
3.14.0.
One example of an application described above is impalad. It links in
libkudu_client and libprotobuf: the former is used to talk to Kudu
servers and the latter is necessary to communicate with other Impala's
backend components via KRPC.
This patch adds the --exclude-libs flag for the GNU linker [2] to
completely hide all the symbols inherited by libkudu_client from
libprotobuf which is statically linked into the Kudu C++ library
in case of RELEASE builds.
As for the rest of libraries statically linked into libkudu_client,
it seems no problems encountered so far if those symbols are just made
local using the version script mechanism, so no other libraries are put
under --exclude-libs linker's flag except for libprotobuf.
[1] https://stackoverflow.com/a/29975019
[2] https://www.man7.org/linux/man-pages/man1/ld.1.html
Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
---
M src/kudu/client/CMakeLists.txt
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/18000/2
--
To view, visit http://gerrit.cloudera.org:8080/18000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
Gerrit-Change-Number: 18000
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[kudu-CR] KUDU-3334 hide protobuf symbols in libkudu client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18000 )
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18000/3/src/kudu/client/CMakeLists.txt
File src/kudu/client/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/18000/3/src/kudu/client/CMakeLists.txt@145
PS3, Line 145: set(LINK_FLAGS "-Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map,--exclude-libs=libprotobuf")
> nit: this line is now too long
Done
--
To view, visit http://gerrit.cloudera.org:8080/18000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
Gerrit-Change-Number: 18000
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Nov 2021 19:31:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3334 hide protobuf symbols in libkudu client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18000 )
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18000/3/src/kudu/client/CMakeLists.txt
File src/kudu/client/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/18000/3/src/kudu/client/CMakeLists.txt@145
PS3, Line 145: set(LINK_FLAGS "-Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/symbols.map,--exclude-libs=libprotobuf")
nit: this line is now too long
--
To view, visit http://gerrit.cloudera.org:8080/18000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
Gerrit-Change-Number: 18000
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Nov 2021 17:20:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3334 hide protobuf symbols in libkudu client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18000 )
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client
......................................................................
KUDU-3334 hide protobuf symbols in libkudu_client
As it turns out, there are conflicts during static initialization of
symbols related to protobuf extensions in an application using
libkudu_client and also linking in libprotobuf on its own. That
seems to be attributed to the creation of two independent descriptor
pools in such cases [1]. At least, such issues became apparent when
both the application and libkudu_client started using libprotobuf
3.14.0.
One example of an application described above is impalad. It links in
libkudu_client and libprotobuf: the former is used to talk to Kudu
servers and the latter is necessary to communicate with other Impala's
backend components via KRPC.
This patch adds the --exclude-libs flag for the GNU linker [2] to
completely hide all the symbols inherited by libkudu_client from
libprotobuf which is statically linked into the Kudu C++ library
in case of RELEASE builds.
As for the rest of libraries statically linked into libkudu_client,
it seems no problems encountered so far if those symbols are just made
local using the version script mechanism, so no other libraries are put
under --exclude-libs linker's flag except for libprotobuf.
[1] https://stackoverflow.com/a/29975019
[2] https://www.man7.org/linux/man-pages/man1/ld.1.html
Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
Reviewed-on: http://gerrit.cloudera.org:8080/18000
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/client/CMakeLists.txt
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
Gerrit-Change-Number: 18000
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[kudu-CR] KUDU-3334 hide protobuf symbols in libkudu client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18000 )
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18000/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18000/1//COMMIT_MSG@30
PS1, Line 30: [1] https://stackoverflow.com/questions/29960871/protobuf-message-object-creation-by-name
nit: maybe link to the answer specifically: https://stackoverflow.com/a/14863432
Or if you want to include the slug, it the shortened URL redirects to https://stackoverflow.com/questions/2222162/how-to-apply-fvisibility-option-to-symbols-in-static-libraries/14863432#14863432
http://gerrit.cloudera.org:8080/#/c/18000/1/src/kudu/client/CMakeLists.txt
File src/kudu/client/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/18000/1/src/kudu/client/CMakeLists.txt@143
PS1, Line 143: version-script option
can you add that it doesn't support exclude-libs either?
--
To view, visit http://gerrit.cloudera.org:8080/18000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
Gerrit-Change-Number: 18000
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Nov 2021 08:31:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3334 hide protobuf symbols in libkudu client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Joe McDonnell, Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18000
to look at the new patch set (#4).
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client
......................................................................
KUDU-3334 hide protobuf symbols in libkudu_client
As it turns out, there are conflicts during static initialization of
symbols related to protobuf extensions in an application using
libkudu_client and also linking in libprotobuf on its own. That
seems to be attributed to the creation of two independent descriptor
pools in such cases [1]. At least, such issues became apparent when
both the application and libkudu_client started using libprotobuf
3.14.0.
One example of an application described above is impalad. It links in
libkudu_client and libprotobuf: the former is used to talk to Kudu
servers and the latter is necessary to communicate with other Impala's
backend components via KRPC.
This patch adds the --exclude-libs flag for the GNU linker [2] to
completely hide all the symbols inherited by libkudu_client from
libprotobuf which is statically linked into the Kudu C++ library
in case of RELEASE builds.
As for the rest of libraries statically linked into libkudu_client,
it seems no problems encountered so far if those symbols are just made
local using the version script mechanism, so no other libraries are put
under --exclude-libs linker's flag except for libprotobuf.
[1] https://stackoverflow.com/a/29975019
[2] https://www.man7.org/linux/man-pages/man1/ld.1.html
Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
---
M src/kudu/client/CMakeLists.txt
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/18000/4
--
To view, visit http://gerrit.cloudera.org:8080/18000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
Gerrit-Change-Number: 18000
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[kudu-CR] KUDU-3334 hide protobuf symbols in libkudu client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18000 )
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
Gerrit-Change-Number: 18000
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Nov 2021 20:52:38 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3334 hide protobuf symbols in libkudu client
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18000 )
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Verified the patch with Impala toolchain. It solved static initialization issue which happened when Impala upgrade protobuf to 3.14.0. Thanks
http://gerrit.cloudera.org:8080/#/c/18000/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18000/2//COMMIT_MSG@11
PS2, Line 11: dynamically
For Impala, libprotobuf is linked as static library.
--
To view, visit http://gerrit.cloudera.org:8080/18000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
Gerrit-Change-Number: 18000
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Nov 2021 16:53:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3334 hide protobuf symbols in libkudu client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18000 )
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18000/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18000/1//COMMIT_MSG@30
PS1, Line 30: [1] https://stackoverflow.com/questions/29960871/protobuf-message-object-creation-by-name
> nit: maybe link to the answer specifically: https://stackoverflow.com/a/148
I added the link to the GNU ld manual page which explains how the --exclude-libs options works. The SO article's link about using --exclude-libs is already present in KUDU-3334.
http://gerrit.cloudera.org:8080/#/c/18000/1/src/kudu/client/CMakeLists.txt
File src/kudu/client/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/18000/1/src/kudu/client/CMakeLists.txt@143
PS1, Line 143: version-script option
> can you add that it doesn't support exclude-libs either?
Done
--
To view, visit http://gerrit.cloudera.org:8080/18000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
Gerrit-Change-Number: 18000
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Nov 2021 16:11:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3334 hide protobuf symbols in libkudu client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18000 )
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18000/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18000/2//COMMIT_MSG@11
PS2, Line 11: dynamically
> For Impala, libprotobuf is linked as static library.
Done
--
To view, visit http://gerrit.cloudera.org:8080/18000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
Gerrit-Change-Number: 18000
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Nov 2021 17:00:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3334 hide protobuf symbols in libkudu client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18000 )
Change subject: KUDU-3334 hide protobuf symbols in libkudu_client
......................................................................
Patch Set 5:
Thanks you guys for quick review!
--
To view, visit http://gerrit.cloudera.org:8080/18000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I584e1f726f8a4f368579c2c323a230fe98e29dee
Gerrit-Change-Number: 18000
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Nov 2021 21:21:42 +0000
Gerrit-HasComments: No