[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on a change in pull request #297: Feat: New metrics and custom configurations in dashboard

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#discussion_r429291032



##########
File path: src/views/components/dashboard/dashboard-item.vue
##########
@@ -93,7 +93,7 @@ limitations under the License. -->
         };
       }
       if (!this.itemConfig.metricLabels && this.itemConfig.metricType === MetricsType.LABELED_VALUE) {
-        this.EDIT_COMP_CONFIG({ index: this.index, values: { metricLabels: 'p50, p75, p90, p95, p99' } });
+        this.EDIT_COMP_CONFIG({ index: this.index, values: { metricLabels: PercentileLabels } });

Review comment:
       This change is not right. The display should configure through UI by the end-users. Because label query covers more use cases than percentile.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org