You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by zs...@apache.org on 2009/10/02 00:21:48 UTC

svn commit: r820824 - in /hadoop/hive/branches/branch-0.4: CHANGES.txt ql/src/java/org/apache/hadoop/hive/ql/util/jdbm/recman/PhysicalRowIdManager.java

Author: zshao
Date: Thu Oct  1 22:21:48 2009
New Revision: 820824

URL: http://svn.apache.org/viewvc?rev=820824&view=rev
Log:
HIVE-864. Fix map-join memory-leak. (Namit Jain via zshao)

Modified:
    hadoop/hive/branches/branch-0.4/CHANGES.txt
    hadoop/hive/branches/branch-0.4/ql/src/java/org/apache/hadoop/hive/ql/util/jdbm/recman/PhysicalRowIdManager.java

Modified: hadoop/hive/branches/branch-0.4/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hive/branches/branch-0.4/CHANGES.txt?rev=820824&r1=820823&r2=820824&view=diff
==============================================================================
--- hadoop/hive/branches/branch-0.4/CHANGES.txt (original)
+++ hadoop/hive/branches/branch-0.4/CHANGES.txt Thu Oct  1 22:21:48 2009
@@ -564,6 +564,9 @@
     HIVE-838. In strict mode, remove error if no partition is selected.
     (Namit Jain via rmurthy)
 
+    HIVE-864. Fix map-join memory-leak.
+    (Namit Jain via zshao)
+
 Release 0.3.1 - Unreleased
 
   INCOMPATIBLE CHANGES

Modified: hadoop/hive/branches/branch-0.4/ql/src/java/org/apache/hadoop/hive/ql/util/jdbm/recman/PhysicalRowIdManager.java
URL: http://svn.apache.org/viewvc/hadoop/hive/branches/branch-0.4/ql/src/java/org/apache/hadoop/hive/ql/util/jdbm/recman/PhysicalRowIdManager.java?rev=820824&r1=820823&r2=820824&view=diff
==============================================================================
--- hadoop/hive/branches/branch-0.4/ql/src/java/org/apache/hadoop/hive/ql/util/jdbm/recman/PhysicalRowIdManager.java (original)
+++ hadoop/hive/branches/branch-0.4/ql/src/java/org/apache/hadoop/hive/ql/util/jdbm/recman/PhysicalRowIdManager.java Thu Oct  1 22:21:48 2009
@@ -138,7 +138,7 @@
      *  Retrieves a record.
      */
     byte[] fetch( Location rowid )
-        throws IOException 
+        throws IOException
     {
         // fetch the record header
         PageCursor curs = new PageCursor( pageman, rowid.getBlock() );
@@ -190,7 +190,7 @@
     {
         Location retval = freeman.get( size );
         if ( retval == null ) {
-            retval = allocNew( 2*size, pageman.getLast( Magic.USED_PAGE ) );
+            retval = allocNew( size, pageman.getLast( Magic.USED_PAGE ) );
         }
         return retval;
     }
@@ -337,7 +337,7 @@
             if ( leftToWrite < toCopy ) {
                 toCopy = leftToWrite;
             }
-            System.arraycopy( data, offsetInBuffer, block.getData(), 
+            System.arraycopy( data, offsetInBuffer, block.getData(),
                               dataOffset, toCopy );
 
             // Go to the next block