[jira] [Commented] (CLOUDSTACK-10375) Do not create DefaultNuageVspSharedNetworkOfferingWithSGService

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487029#comment-16487029 ] 

ASF GitHub Bot commented on CLOUDSTACK-10375:
---------------------------------------------

fmaximus opened a new pull request #2667: CLOUDSTACK-10375: Don't create DefaultNuageVspSharedNetworkOfferingWithSGService
URL: https://github.com/apache/cloudstack/pull/2667
 
 
   ## Description
   <!--- Describe your changes in detail -->
   Nuage Plugin currently creates a Network Offering on startup.
   We stop creating this as it is unused.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   Ran regression test on a Nuage KVM setup.
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.
   - [x] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [x] All relevant new and existing integration tests have passed.
   - [x] A full integration testsuite with all test that can run on my environment has passed.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Do not create DefaultNuageVspSharedNetworkOfferingWithSGService
> ---------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10375
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10375
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.11.0.0
>         Environment: ACS 4.11 + Nuage
>            Reporter: Raf Smeets
>            Assignee: Frank Maximus
>            Priority: Minor
>
> NuageVsp plugin is creating a network offering called DefaultNuageVspSharedNetworkOfferingWithSGService.
> This offering is unsupported, so do not create it anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)