You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "ruanwenjun (via GitHub)" <gi...@apache.org> on 2023/03/04 13:21:20 UTC

[GitHub] [incubator-seatunnel] ruanwenjun opened a new pull request, #4268: [Improvement] Change HashMap to LinkedHashMap in SimpleConfigObject

ruanwenjun opened a new pull request, #4268:
URL: https://github.com/apache/incubator-seatunnel/pull/4268

   ## Purpose of this pull request
   
   Due to the Config doesn't support set value at given order. e.g.
   If we use 
   ```
   config
   .withValue("a", xx)
   .withValue("b", yy)
   .withValue("c", zz)
   ```
   The out put will not in a, b, c order, since SimpleConfigObject will use HashMap to store the config.
   
   This PR will change the HashMap to LinkedHashMap.
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
     2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
   * [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4268: [Improvement] Change HashMap to LinkedHashMap in SimpleConfigObject

Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #4268:
URL: https://github.com/apache/incubator-seatunnel/pull/4268#issuecomment-1454740051

   I also make some changes on it in #4134 , should we unified it in one pull request?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #4268: [Improvement] Change HashMap to LinkedHashMap in SimpleConfigObject

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #4268:
URL: https://github.com/apache/incubator-seatunnel/pull/4268#issuecomment-1454765101

   > #4134
   
   OK, I will close this PR if https://github.com/apache/incubator-seatunnel/pull/4134 will use LinkedHashMap in SimpleConfigObject.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun closed pull request #4268: [Improvement] Change HashMap to LinkedHashMap in SimpleConfigObject

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun closed pull request #4268: [Improvement] Change HashMap to LinkedHashMap in SimpleConfigObject
URL: https://github.com/apache/incubator-seatunnel/pull/4268


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #4268: [Improve][shade][Config] Change HashMap to LinkedHashMap in SimpleConfigObject

Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 merged PR #4268:
URL: https://github.com/apache/incubator-seatunnel/pull/4268


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org