[GitHub] [pinot] jtao15 commented on a diff in pull request #10964: Allow custom segment grouping in MergeRollupTask based on lineage metadata

["jtao15 (via GitHub)" <gi...@apache.org>]

jtao15 commented on code in PR #10964:
URL: https://github.com/apache/pinot/pull/10964#discussion_r1243152915


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/lineage/LineageManager.java:
##########
@@ -70,4 +71,14 @@ void updateLineageForRevertReplaceSegments(TableConfig tableConfig, String linea
    */
   void updateLineageForRetention(TableConfig tableConfig, SegmentLineage lineage, List<String> allSegments,
       List<String> segmentsToDelete, Set<String> consumingSegments);
+
+  /**
+   * Get segment zk metadata groups for MergeRollupTask
+   * @param tableConfig
+   * @param lineage
+   * @param segments
+   * @return segment zk metadata groups

Review Comment:
   This basically returns multiple Group/List of SegmentZkMetadata. Each group/list have the segments that should be merged together, segments from different groups should not be merged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org