You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Bharath Mundlapudi (JIRA)" <ji...@apache.org> on 2011/06/02 01:08:47 UTC
[jira] [Created] (HDFS-2023) Backport of NPE for File.list and
File.listFiles
Backport of NPE for File.list and File.listFiles
------------------------------------------------
Key: HDFS-2023
URL: https://issues.apache.org/jira/browse/HDFS-2023
Project: Hadoop HDFS
Issue Type: Bug
Components: data-node
Affects Versions: 0.20.205.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
Fix For: 0.20.205.0
Since we have multiple Jira's in trunk for common and hdfs, I am creating another jira for this issue.
This patch addresses the following:
1. Provides FileUtil API for list and listFiles which throws IOException for null cases.
2. Replaces most of the code where JDK file API with FileUtil API.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2023) Backport of NPE for File.list and
File.listFiles
Posted by "Bharath Mundlapudi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042519#comment-13042519 ]
Bharath Mundlapudi commented on HDFS-2023:
------------------------------------------
Hi Eli,
I wanted to have this change in the same Jira as 0.23 but those were reviewed and committed. So I created this one. Also, i could have done multiple patches in those same Jiras but this will be not good for reviwers. On the positive side, we can have this single Jira for all 0.20.*.
But i agree with you on having same Jira for backporting.
> Backport of NPE for File.list and File.listFiles
> ------------------------------------------------
>
> Key: HDFS-2023
> URL: https://issues.apache.org/jira/browse/HDFS-2023
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 0.20.205.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.205.0
>
> Attachments: HDFS-2023-1.patch
>
>
> Since we have multiple Jira's in trunk for common and hdfs, I am creating another jira for this issue.
> This patch addresses the following:
> 1. Provides FileUtil API for list and listFiles which throws IOException for null cases.
> 2. Replaces most of the code where JDK file API with FileUtil API.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-2023) Backport of NPE for File.list and
File.listFiles
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley resolved HDFS-2023.
------------------------------
Resolution: Fixed
Committed to 0.20-security. Thanks Bharath!
> Backport of NPE for File.list and File.listFiles
> ------------------------------------------------
>
> Key: HDFS-2023
> URL: https://issues.apache.org/jira/browse/HDFS-2023
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 0.20.205.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.205.0
>
> Attachments: HDFS-2023-1.patch
>
>
> Since we have multiple Jira's in trunk for common and hdfs, I am creating another jira for this issue.
> This patch addresses the following:
> 1. Provides FileUtil API for list and listFiles which throws IOException for null cases.
> 2. Replaces most of the code where JDK file API with FileUtil API.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2023) Backport of NPE for File.list and
File.listFiles
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042531#comment-13042531 ]
Matt Foley commented on HDFS-2023:
----------------------------------
Eli, I asked Bharath to make a separate Jira, because this set of changes isn't the same content as the previously existing Jiras. Granted he could split this into the same four chunks as represented by HADOOP-7342, HADOOP-7322, HDFS-1934, and HDFS-2019. But it seemed more efficient to do them together for v20, since there is no HADOOP/HDFS split.
Do you prefer to have four patches instead of one?
> Backport of NPE for File.list and File.listFiles
> ------------------------------------------------
>
> Key: HDFS-2023
> URL: https://issues.apache.org/jira/browse/HDFS-2023
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 0.20.205.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.205.0
>
> Attachments: HDFS-2023-1.patch
>
>
> Since we have multiple Jira's in trunk for common and hdfs, I am creating another jira for this issue.
> This patch addresses the following:
> 1. Provides FileUtil API for list and listFiles which throws IOException for null cases.
> 2. Replaces most of the code where JDK file API with FileUtil API.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2023) Backport of NPE for File.list and
File.listFiles
Posted by "Bharath Mundlapudi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bharath Mundlapudi updated HDFS-2023:
-------------------------------------
Attachment: HDFS-2023-1.patch
Attaching a patch for this issue.
> Backport of NPE for File.list and File.listFiles
> ------------------------------------------------
>
> Key: HDFS-2023
> URL: https://issues.apache.org/jira/browse/HDFS-2023
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 0.20.205.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.205.0
>
> Attachments: HDFS-2023-1.patch
>
>
> Since we have multiple Jira's in trunk for common and hdfs, I am creating another jira for this issue.
> This patch addresses the following:
> 1. Provides FileUtil API for list and listFiles which throws IOException for null cases.
> 2. Replaces most of the code where JDK file API with FileUtil API.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2023) Backport of NPE for File.list and
File.listFiles
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042509#comment-13042509 ]
Eli Collins commented on HDFS-2023:
-----------------------------------
In the future how about using multiple fix versions on the original jira so we don't have different jira numbers for the same change? Ie we don't have multiple jiras for an issue that goes into both 0.23 and 0.22, so no need for a jira going into 0.23 and 0.20.205.
> Backport of NPE for File.list and File.listFiles
> ------------------------------------------------
>
> Key: HDFS-2023
> URL: https://issues.apache.org/jira/browse/HDFS-2023
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 0.20.205.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.205.0
>
> Attachments: HDFS-2023-1.patch
>
>
> Since we have multiple Jira's in trunk for common and hdfs, I am creating another jira for this issue.
> This patch addresses the following:
> 1. Provides FileUtil API for list and listFiles which throws IOException for null cases.
> 2. Replaces most of the code where JDK file API with FileUtil API.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2023) Backport of NPE for File.list and
File.listFiles
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044221#comment-13044221 ]
Matt Foley commented on HDFS-2023:
----------------------------------
+1 for code review, pending local test-patch results.
> Backport of NPE for File.list and File.listFiles
> ------------------------------------------------
>
> Key: HDFS-2023
> URL: https://issues.apache.org/jira/browse/HDFS-2023
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 0.20.205.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.205.0
>
> Attachments: HDFS-2023-1.patch
>
>
> Since we have multiple Jira's in trunk for common and hdfs, I am creating another jira for this issue.
> This patch addresses the following:
> 1. Provides FileUtil API for list and listFiles which throws IOException for null cases.
> 2. Replaces most of the code where JDK file API with FileUtil API.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2023) Backport of NPE for File.list and
File.listFiles
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042604#comment-13042604 ]
Eli Collins commented on HDFS-2023:
-----------------------------------
I don't feel strongly. It's easier for users if the same issue is represented by a single jira across versions (you'll see a patch for different branches on the same jira) but if the content is different (not the patch but different goal/change) then a new jira makes sense.
> Backport of NPE for File.list and File.listFiles
> ------------------------------------------------
>
> Key: HDFS-2023
> URL: https://issues.apache.org/jira/browse/HDFS-2023
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 0.20.205.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.205.0
>
> Attachments: HDFS-2023-1.patch
>
>
> Since we have multiple Jira's in trunk for common and hdfs, I am creating another jira for this issue.
> This patch addresses the following:
> 1. Provides FileUtil API for list and listFiles which throws IOException for null cases.
> 2. Replaces most of the code where JDK file API with FileUtil API.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2023) Backport of NPE for File.list and
File.listFiles
Posted by "Bharath Mundlapudi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044243#comment-13044243 ]
Bharath Mundlapudi commented on HDFS-2023:
------------------------------------------
I have run local test-patch on this patch and here are the results for this branch. -1s are not related to this patch.
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 9 new or modified tests.
[exec]
[exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories.
Javadoc 6 warnings and Eclipse classpath are not related to this patch.
--------------------------------------------------------------------
[javadoc] /export/space/branch-0.20-security.qa/hadoop-common/src/core/org/apache/hadoop/security/SecurityUtil.java:36: warning: sun.security.jgss.krb5.Krb5Util
is Sun proprietary API and may be removed in a future release
[javadoc] import sun.security.jgss.krb5.Krb5Util;
[javadoc] ^
[javadoc] /export/space/branch-0.20-security.qa/hadoop-common/src/core/org/apache/hadoop/security/SecurityUtil.java:37: warning: sun.security.krb5.Credentials is
Sun proprietary API and may be removed in a future release
[javadoc] import sun.security.krb5.Credentials;
[javadoc] ^
[javadoc] /export/space/branch-0.20-security.qa/hadoop-common/src/core/org/apache/hadoop/security/SecurityUtil.java:38: warning: sun.security.krb5.PrincipalName
is Sun proprietary API and may be removed in a future release
[javadoc] import sun.security.krb5.PrincipalName;
[javadoc] ^
[javadoc] /export/space/branch-0.20-security.qa/hadoop-common/src/core/org/apache/hadoop/security/KerberosName.java:29: warning: sun.security.krb5.Config is Sun
proprietary API and may be removed in a future release
[javadoc] import sun.security.krb5.Config;
[javadoc] ^
[javadoc] /export/space/branch-0.20-security.qa/hadoop-common/src/core/org/apache/hadoop/security/KerberosName.java:30: warning: sun.security.krb5.KrbException i
s Sun proprietary API and may be removed in a future release
[javadoc] import sun.security.krb5.KrbException;
[javadoc] ^
[javadoc] /export/space/branch-0.20-security.qa/hadoop-common/src/core/org/apache/hadoop/security/KerberosName.java:76: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release
[javadoc] private static Config kerbConf;
[javadoc] ^
[javadoc] Standard Doclet version 1.6.0_17
[javadoc] Building tree for all the packages and classes...
[javadoc] Building index for all the packages and classes...
[javadoc] Building index for all classes...
[javadoc] Generating /export/space/branch-0.20-security.qa/hadoop-common/build/docs/api/stylesheet.css...
[javadoc] 6 warnings
---------------------------------------------------------------
> Backport of NPE for File.list and File.listFiles
> ------------------------------------------------
>
> Key: HDFS-2023
> URL: https://issues.apache.org/jira/browse/HDFS-2023
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 0.20.205.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.205.0
>
> Attachments: HDFS-2023-1.patch
>
>
> Since we have multiple Jira's in trunk for common and hdfs, I am creating another jira for this issue.
> This patch addresses the following:
> 1. Provides FileUtil API for list and listFiles which throws IOException for null cases.
> 2. Replaces most of the code where JDK file API with FileUtil API.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2023) Backport of NPE for File.list and
File.listFiles
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HDFS-2023:
--------------------------------
Fix Version/s: (was: 0.20.205.0)
> Backport of NPE for File.list and File.listFiles
> ------------------------------------------------
>
> Key: HDFS-2023
> URL: https://issues.apache.org/jira/browse/HDFS-2023
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 0.20.205.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.204.0
>
> Attachments: HDFS-2023-1.patch
>
>
> Since we have multiple Jira's in trunk for common and hdfs, I am creating another jira for this issue.
> This patch addresses the following:
> 1. Provides FileUtil API for list and listFiles which throws IOException for null cases.
> 2. Replaces most of the code where JDK file API with FileUtil API.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2023) Backport of NPE for File.list and
File.listFiles
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HDFS-2023:
--------------------------------
Fix Version/s: 0.20.204.0
> Backport of NPE for File.list and File.listFiles
> ------------------------------------------------
>
> Key: HDFS-2023
> URL: https://issues.apache.org/jira/browse/HDFS-2023
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node
> Affects Versions: 0.20.205.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Fix For: 0.20.204.0, 0.20.205.0
>
> Attachments: HDFS-2023-1.patch
>
>
> Since we have multiple Jira's in trunk for common and hdfs, I am creating another jira for this issue.
> This patch addresses the following:
> 1. Provides FileUtil API for list and listFiles which throws IOException for null cases.
> 2. Replaces most of the code where JDK file API with FileUtil API.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira