You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry via Review Board <no...@reviews.apache.org> on 2019/08/11 04:56:29 UTC
Review Request 71270: Table-level Export & Import: Preserving REPL
Additional Info
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71270/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3362
https://issues.apache.org/jira/browse/ATLAS-3362
Repository: atlas
Description
-------
**Background**
Existing logic for preserving REPL _additionalInfo_ uses the first guid in the _exportOrder_ list. This works fine for database-level replication as DB GUID is always available in the list.
In case of table-level replication the list of tables vary based on what _changeMarker_ is applied.
Thus, there needs to be a constant GUID against which this REPL additional info can be preserved.
**Approach**
- Get the first guid from the in the _exportOrder_.
- Fetch the entity using the guid.
- If it is of type hive_db, use it.
- If it is hive_table or hive_column, fetch the DB by constructing DB's _qualifiedName_ from the entity's qualified name.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 9bf30f116
repository/src/test/java/org/apache/atlas/repository/impexp/ReplicationEntityAttributeTest.java 829390b76
Diff: https://reviews.apache.org/r/71270/diff/1/
Testing
-------
**Functional tests**
Executed scenarios of table-level replication.
**Unit tests**
Additional test.
Thanks,
Ashutosh Mestry
Re: Review Request 71270: Table-level Export & Import: Preserving REPL
Additional Info
Posted by Nikhil Bonte <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71270/#review217169
-----------------------------------------------------------
Ship it!
Ship It!
- Nikhil Bonte
On Aug. 11, 2019, 4:56 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71270/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2019, 4:56 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3362
> https://issues.apache.org/jira/browse/ATLAS-3362
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Background**
> Existing logic for preserving REPL _additionalInfo_ uses the first guid in the _exportOrder_ list. This works fine for database-level replication as DB GUID is always available in the list.
>
> In case of table-level replication the list of tables vary based on what _changeMarker_ is applied.
>
> Thus, there needs to be a constant GUID against which this REPL additional info can be preserved.
>
> **Approach**
> - Get the first guid from the in the _exportOrder_.
> - Fetch the entity using the guid.
> - If it is of type hive_db, use it.
> - If it is hive_table or hive_column, fetch the DB by constructing DB's _qualifiedName_ from the entity's qualified name.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 9bf30f116
> repository/src/test/java/org/apache/atlas/repository/impexp/ReplicationEntityAttributeTest.java 829390b76
>
>
> Diff: https://reviews.apache.org/r/71270/diff/1/
>
>
> Testing
> -------
>
> **Functional tests**
> Executed scenarios of table-level replication.
>
> **Unit tests**
> Additional test.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 71270: Table-level Export & Import: Preserving REPL
Additional Info
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71270/#review217173
-----------------------------------------------------------
Ship it!
Ship It!
- Nixon Rodrigues
On Aug. 11, 2019, 4:56 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71270/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2019, 4:56 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3362
> https://issues.apache.org/jira/browse/ATLAS-3362
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Background**
> Existing logic for preserving REPL _additionalInfo_ uses the first guid in the _exportOrder_ list. This works fine for database-level replication as DB GUID is always available in the list.
>
> In case of table-level replication the list of tables vary based on what _changeMarker_ is applied.
>
> Thus, there needs to be a constant GUID against which this REPL additional info can be preserved.
>
> **Approach**
> - Get the first guid from the in the _exportOrder_.
> - Fetch the entity using the guid.
> - If it is of type hive_db, use it.
> - If it is hive_table or hive_column, fetch the DB by constructing DB's _qualifiedName_ from the entity's qualified name.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 9bf30f116
> repository/src/test/java/org/apache/atlas/repository/impexp/ReplicationEntityAttributeTest.java 829390b76
>
>
> Diff: https://reviews.apache.org/r/71270/diff/1/
>
>
> Testing
> -------
>
> **Functional tests**
> Executed scenarios of table-level replication.
>
> **Unit tests**
> Additional test.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>