You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Vishanth <gi...@git.apache.org> on 2015/01/13 10:03:23 UTC
[GitHub] stratos pull request: Update DefaultApplicationParser.java
GitHub user Vishanth opened a pull request:
https://github.com/apache/stratos/pull/168
Update DefaultApplicationParser.java
correcting "getTeantAdminUsername" to "getTenantAdminUsername"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Vishanth/stratos patch-5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/stratos/pull/168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #168
----
commit 38fde699c35c3f83415bbe5383696aff330c89a0
Author: Vishanth <vi...@gmail.com>
Date: 2015-01-13T09:03:15Z
Update DefaultApplicationParser.java
correcting "getTeantAdminUsername" to "getTenantAdminUsername"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Update DefaultApplicationParser.java
Posted by Vishanth <gi...@git.apache.org>.
Github user Vishanth closed the pull request at:
https://github.com/apache/stratos/pull/168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Update DefaultApplicationParser.java
Posted by Vishanth <gi...@git.apache.org>.
Github user Vishanth commented on the pull request:
https://github.com/apache/stratos/pull/168#issuecomment-69717669
Corrected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] stratos pull request: Update DefaultApplicationParser.java
Posted by Vishanth Balasubramaniam <vi...@wso2.com>.
Ok I will correct and send the PR again
On Tue, Jan 13, 2015 at 2:57 PM, Manula Chathurika Thantriwatte <
manulac@wso2.com> wrote:
> Hi Vishanth,
>
> Mistakenly you have add invalid code line at [1]. Can you correct it and
> send the pull request again.
>
> [1]
> https://github.com/apache/stratos/pull/168/files#diff-52a6fbcd6b8bef072ac48ef8fb1b106aR178
>
> Thanks !
>
> On Tue, Jan 13, 2015 at 2:48 PM, manulachathurika <gi...@git.apache.org>
> wrote:
>
>> Github user manulachathurika commented on the pull request:
>>
>> https://github.com/apache/stratos/pull/168#issuecomment-69715905
>>
>> Hi Vishanth,
>>
>> Doesn't this gives a compilation error.
>>
>> [1]
>> https://github.com/apache/stratos/pull/168/files#diff-52a6fbcd6b8bef072ac48ef8fb1b106aR178
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
>
>
> --
> Regards,
> Manula Chathurika Thantriwatte
> Software Engineer
> WSO2 Inc. : http://wso2.com
> lean . enterprise . middleware
>
> email : manulac@wso2.com / manula@apache.org
> phone : +94 772492511
> blog : http://manulachathurika.blogspot.com/
>
>
>
>
--
*Vishanth Balasubramaniam*
Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware
mobile: *+94771737718*
about me: *http://about.me/vishanth <http://about.me/vishanth>*
Re: [GitHub] stratos pull request: Update DefaultApplicationParser.java
Posted by Vishanth Balasubramaniam <vi...@wso2.com>.
Thanks Manula
On Tue, Jan 13, 2015 at 3:00 PM, Manula Chathurika Thantriwatte <
manulac@wso2.com> wrote:
> Hi Vishanth,
>
> I have correct that issue and commit the changed.
>
> Thanks !
>
> On Tue, Jan 13, 2015 at 2:57 PM, Manula Chathurika Thantriwatte <
> manulac@wso2.com> wrote:
>
>> Hi Vishanth,
>>
>> Mistakenly you have add invalid code line at [1]. Can you correct it and
>> send the pull request again.
>>
>> [1]
>> https://github.com/apache/stratos/pull/168/files#diff-52a6fbcd6b8bef072ac48ef8fb1b106aR178
>>
>> Thanks !
>>
>> On Tue, Jan 13, 2015 at 2:48 PM, manulachathurika <gi...@git.apache.org>
>> wrote:
>>
>>> Github user manulachathurika commented on the pull request:
>>>
>>> https://github.com/apache/stratos/pull/168#issuecomment-69715905
>>>
>>> Hi Vishanth,
>>>
>>> Doesn't this gives a compilation error.
>>>
>>> [1]
>>> https://github.com/apache/stratos/pull/168/files#diff-52a6fbcd6b8bef072ac48ef8fb1b106aR178
>>>
>>>
>>> ---
>>> If your project is set up for it, you can reply to this email and have
>>> your
>>> reply appear on GitHub as well. If your project does not have this
>>> feature
>>> enabled and wishes so, or if the feature is enabled but not working,
>>> please
>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>> ticket
>>> with INFRA.
>>> ---
>>>
>>
>>
>>
>> --
>> Regards,
>> Manula Chathurika Thantriwatte
>> Software Engineer
>> WSO2 Inc. : http://wso2.com
>> lean . enterprise . middleware
>>
>> email : manulac@wso2.com / manula@apache.org
>> phone : +94 772492511
>> blog : http://manulachathurika.blogspot.com/
>>
>>
>>
>>
>
>
> --
> Regards,
> Manula Chathurika Thantriwatte
> Software Engineer
> WSO2 Inc. : http://wso2.com
> lean . enterprise . middleware
>
> email : manulac@wso2.com / manula@apache.org
> phone : +94 772492511
> blog : http://manulachathurika.blogspot.com/
>
>
>
>
--
*Vishanth Balasubramaniam*
Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware
mobile: *+94771737718*
about me: *http://about.me/vishanth <http://about.me/vishanth>*
Re: [GitHub] stratos pull request: Update DefaultApplicationParser.java
Posted by Manula Chathurika Thantriwatte <ma...@wso2.com>.
Hi Vishanth,
I have correct that issue and commit the changed.
Thanks !
On Tue, Jan 13, 2015 at 2:57 PM, Manula Chathurika Thantriwatte <
manulac@wso2.com> wrote:
> Hi Vishanth,
>
> Mistakenly you have add invalid code line at [1]. Can you correct it and
> send the pull request again.
>
> [1]
> https://github.com/apache/stratos/pull/168/files#diff-52a6fbcd6b8bef072ac48ef8fb1b106aR178
>
> Thanks !
>
> On Tue, Jan 13, 2015 at 2:48 PM, manulachathurika <gi...@git.apache.org>
> wrote:
>
>> Github user manulachathurika commented on the pull request:
>>
>> https://github.com/apache/stratos/pull/168#issuecomment-69715905
>>
>> Hi Vishanth,
>>
>> Doesn't this gives a compilation error.
>>
>> [1]
>> https://github.com/apache/stratos/pull/168/files#diff-52a6fbcd6b8bef072ac48ef8fb1b106aR178
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
>
>
> --
> Regards,
> Manula Chathurika Thantriwatte
> Software Engineer
> WSO2 Inc. : http://wso2.com
> lean . enterprise . middleware
>
> email : manulac@wso2.com / manula@apache.org
> phone : +94 772492511
> blog : http://manulachathurika.blogspot.com/
>
>
>
>
--
Regards,
Manula Chathurika Thantriwatte
Software Engineer
WSO2 Inc. : http://wso2.com
lean . enterprise . middleware
email : manulac@wso2.com / manula@apache.org
phone : +94 772492511
blog : http://manulachathurika.blogspot.com/
Re: [GitHub] stratos pull request: Update DefaultApplicationParser.java
Posted by Manula Chathurika Thantriwatte <ma...@wso2.com>.
Hi Vishanth,
Mistakenly you have add invalid code line at [1]. Can you correct it and
send the pull request again.
[1]
https://github.com/apache/stratos/pull/168/files#diff-52a6fbcd6b8bef072ac48ef8fb1b106aR178
Thanks !
On Tue, Jan 13, 2015 at 2:48 PM, manulachathurika <gi...@git.apache.org>
wrote:
> Github user manulachathurika commented on the pull request:
>
> https://github.com/apache/stratos/pull/168#issuecomment-69715905
>
> Hi Vishanth,
>
> Doesn't this gives a compilation error.
>
> [1]
> https://github.com/apache/stratos/pull/168/files#diff-52a6fbcd6b8bef072ac48ef8fb1b106aR178
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
--
Regards,
Manula Chathurika Thantriwatte
Software Engineer
WSO2 Inc. : http://wso2.com
lean . enterprise . middleware
email : manulac@wso2.com / manula@apache.org
phone : +94 772492511
blog : http://manulachathurika.blogspot.com/
[GitHub] stratos pull request: Update DefaultApplicationParser.java
Posted by manulachathurika <gi...@git.apache.org>.
Github user manulachathurika commented on the pull request:
https://github.com/apache/stratos/pull/168#issuecomment-69715905
Hi Vishanth,
Doesn't this gives a compilation error.
[1] https://github.com/apache/stratos/pull/168/files#diff-52a6fbcd6b8bef072ac48ef8fb1b106aR178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---