You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2025/04/17 07:11:21 UTC
[PR] Update PolarisCredentialProperty.java [polaris]
wgtmac opened a new pull request, #1387:
URL: https://github.com/apache/polaris/pull/1387
Fix `adls.sas-token.` to `adls.sas-token`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update PolarisCredentialProperty.java [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #1387:
URL: https://github.com/apache/polaris/pull/1387#issuecomment-2825519107
Closing this for now as we seem to be in agreement that the current behavior is correct, but big +1 on fixing this upstream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update PolarisCredentialProperty.java [polaris]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1387:
URL: https://github.com/apache/polaris/pull/1387#issuecomment-2812018853
I am working on credentials vending while integrating our lakehouse with Polaris catalog and happened to see this possible typo, am I correct?
At the same time, I have a question about the keys for storage credentials. The spec has the following description for `LoadTableResult`.
```
## AWS Configurations
The following configurations should be respected when working with tables stored in AWS S3
- `client.region`: region to configure client for making requests to AWS
- `s3.access-key-id`: id for credentials that provide access to the data in S3
- `s3.secret-access-key`: secret for credentials that provide access to data in S3
- `s3.session-token`: if present, this value should be used for as the session token
- `s3.remote-signing-enabled`: if `true` remote signing should be performed as described in the `s3-signer-open-api.yaml` specification
## Storage Credentials
Credentials for ADLS / GCS / S3 / ... are provided through the `storage-credentials` field.
Clients must first check whether the respective credentials exist in the `storage-credentials` field before checking the `config` for credentials.
```
Does it mean that different catalog vendors are free to use whatever keys for different storage in the `storage-credentials`? Is there any chance to standardize them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update PolarisCredentialProperty.java [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard closed pull request #1387: Update PolarisCredentialProperty.java
URL: https://github.com/apache/polaris/pull/1387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update PolarisCredentialProperty.java [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #1387:
URL: https://github.com/apache/polaris/pull/1387#issuecomment-2812074957
@wgtmac I think standardizing these in the Iceberg spec upstream is is a good idea, though there will always have to be some fuzziness to account for custom FileIO implementations. On the Polaris side, we should just vend whatever the Iceberg REST clients are expecting IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update PolarisCredentialProperty.java [polaris]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1387:
URL: https://github.com/apache/polaris/pull/1387#issuecomment-2812036423
OK, I've found this so my PR does not make sense: https://github.com/apache/iceberg/blob/main/azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java#L38
But I still want to ask if we can document these in the Iceberg rest catalog spec instead of reading these from each vendor's code or documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update PolarisCredentialProperty.java [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #1387:
URL: https://github.com/apache/polaris/pull/1387#issuecomment-2813606304
+1 to standardize in Iceberg spec, so that, engines wont' be confused by different keys. We could also promote the same keys from Polaris.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org