[GitHub] rabbah commented on a change in pull request #3366: Adds method deleteAttachments to ArtifactStore

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #3366: Adds method deleteAttachments to ArtifactStore
URL: https://github.com/apache/incubator-openwhisk/pull/3366#discussion_r171842936
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/database/CouchDbRestStore.scala
 ##########
 @@ -456,6 +456,11 @@ class CouchDbRestStore[DocumentAbstraction <: DocumentSerializer](dbProtocol: St
           ErrorLevel))
   }
 
+  override protected[core] def deleteAttachments[T](doc: DocInfo)(implicit transid: TransactionId): Future[Boolean] =
+    //For CouchDB attachments lifecycle is tied to document. So if the
 
 Review comment:
   I prefer a stronger warning here:
   
   ```
   // NOTE: this method is not intended for standalone use for CouchDB.
   // To delete attachments, it is expected that the entire document is deleted.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services